appview/pages/templates/repo/pulls: disable pointer events on "history" header #1226

Clicking the "History" header was allowed but did nothing meaningful, just flicker the view.

This commit disables that behavior while keeping the relevant information like the number of comments and the number of rounds selectable as they should.

Signed-off-by: eti eti@eti.tf

+8 -4

1 changed file

Diff round #0

expand all

appview

pages

templates

repo

pulls

pull.html

+8 -4

appview/pages/templates/repo/pulls/pull.html

··· 119 119 {{ $id := index . 0 }} 120 120 {{ $target := index . 1 }} 121 121 {{ $direction := index . 2 }} 122 - <div id="{{ $id }}" 122 + <div id="{{ $id }}" 123 123 data-resizer="vertical" 124 124 data-target="{{ $target }}" 125 125 data-direction="{{ $direction }}" ··· 179 179 text-white md:text-black md:dark:text-white 180 180 {{ $bgColor }} 181 181 md:bg-white md:dark:bg-gray-800 182 - drop-shadow-sm border-t md:border-x border-gray-200 dark:border-gray-700"> 182 + drop-shadow-sm border-t md:border-x border-gray-200 dark:border-gray-700 183 + pointer-events-none 184 + "> 183 185 <h2 class="">History</h2> 184 - {{ template "subsPanelSummary" $ }} 186 + <span class="pointer-events-auto cursor-text"> 187 + {{ template "subsPanelSummary" $ }} 188 + </span> 185 189 </summary> 186 190 <div class="max-h-[85vh] md:max-h-[calc(100vh-3rem-3rem)] w-full flex flex-col-reverse gap-4 overflow-y-auto bg-slate-100 dark:bg-gray-900 md:bg-transparent"> 187 191 {{ template "submissions" $root }} ··· 318 322 {{ $round := $item.RoundNumber }} 319 323 <div class="flex gap-2 items-center justify-between mb-1"> 320 324 <span class="inline-flex items-center gap-2 text-sm text-gray-500 dark:text-gray-400 pt-2"> 321 - {{ $handle := resolve $root.Pull.OwnerDid }} 325 + {{ $handle := resolve $root.Pull.OwnerDid }} 322 326 <a class="text-gray-500 dark:text-gray-400 hover:text-gray-500 dark:hover:text-gray-300" href="/{{ $handle }}">{{ $handle }}</a> 323 327 submitted 324 328 <span class="px-2 py-0.5 text-black dark:text-white bg-gray-100 dark:bg-gray-700 border-gray-300 dark:border-gray-600 rounded font-mono text-xs border">

History

2 rounds 4 comments

eti.tf submitted #1 3d

diff interdiff

1 commit

expand

016b2029

appview/pages/templates/repo/pulls: disable pointer events on "history" header

expand 0 comments

pull request successfully merged

eti.tf submitted #0 6d

1 commit

expand

de9c6ab1

appview/pages/templates/repo/pulls: disable pointer events on "history" header

expand 4 comments

oppi.li 3d

appview/pages/templates/repo/pulls/pull.html:186: what does this pointer-events-auto here do?

eti.tf 3d

it re-sets the pointer-events-none of the parent.
if we don't add pointer-events-auto on line 186 then there is no possibility for the user to select the text.
maybe they'd want to select the amount of rounds or the amount of comments to copy and paste them somewhere. i think this is a proper common behavior!

oppi.li 3d

makes sense!

oppi.li 3d

lgtm barring conflicts!