tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages/templates/repo/pulls: disable pointer events on "history" header #1226

merged opened by eti.tf targeting master from eti.tf/core: eti/tan-364-history-header-flicker-on-click

Clicking the "History" header was allowed but did nothing meaningful, just flicker the view.

This commit disables that behavior while keeping the relevant information like the number of comments and the number of rounds selectable as they should.

Signed-off-by: eti eti@eti.tf

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xu5apv6kmu5jp7g5hwdnej42/sh.tangled.repo.pull/3mi2dk7sj6u22
+6 -2
Diff #1
+6 -2
appview/pages/templates/repo/pulls/pull.html
··· 179 179 text-white md:text-black md:dark:text-white 180 180 {{ $bgColor }} 181 181 md:bg-white md:dark:bg-gray-800 182 - drop-shadow-sm border-t md:border-x border-gray-200 dark:border-gray-700"> 182 + drop-shadow-sm border-t md:border-x border-gray-200 dark:border-gray-700 183 + pointer-events-none 184 + "> 183 185 <h2 class="">History</h2> 184 - {{ template "subsPanelSummary" $ }} 186 + <span class="pointer-events-auto cursor-text"> 187 + {{ template "subsPanelSummary" $ }} 188 + </span> 185 189 </summary> 186 190 <div class="max-h-[85vh] md:max-h-[calc(100vh-3rem-3rem)] w-full flex flex-col-reverse gap-4 overflow-y-auto bg-slate-100 dark:bg-gray-900 md:bg-transparent"> 187 191 {{ template "submissions" $root }}

History

2 rounds 4 comments
sign up or login to add to the discussion
eti.tf submitted #1
interdiff
1 commit
expand
016b2029
appview/pages/templates/repo/pulls: disable pointer events on "history" header
expand 0 comments
pull request successfully merged
eti.tf submitted #0
diff
1 commit
expand
de9c6ab1
appview/pages/templates/repo/pulls: disable pointer events on "history" header
expand 4 comments
oppi.li

appview/pages/templates/repo/pulls/pull.html:186: what does this pointer-events-auto here do?

eti.tf

it re-sets the pointer-events-none of the parent.
if we don't add pointer-events-auto on line 186 then there is no possibility for the user to select the text.
maybe they'd want to select the amount of rounds or the amount of comments to copy and paste them somewhere. i think this is a proper common behavior!

oppi.li

makes sense!

oppi.li

lgtm barring conflicts!