tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages/templates/repo/pulls: disable pointer events on "history" header #1226

merged opened by eti.tf targeting master from eti.tf/core: eti/tan-364-history-header-flicker-on-click

Clicking the "History" header was allowed but did nothing meaningful, just flicker the view.

This commit disables that behavior while keeping the relevant information like the number of comments and the number of rounds selectable as they should.

Signed-off-by: eti eti@eti.tf

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xu5apv6kmu5jp7g5hwdnej42/sh.tangled.repo.pull/3mi2dk7sj6u22
+2 -2
Interdiff #0 → #1
+2 -2
appview/pages/templates/repo/pulls/pull.html
··· 119 119 {{ $id := index . 0 }} 120 120 {{ $target := index . 1 }} 121 121 {{ $direction := index . 2 }} 122 - <div id="{{ $id }}" 122 + <div id="{{ $id }}" 123 123 data-resizer="vertical" 124 124 data-target="{{ $target }}" 125 125 data-direction="{{ $direction }}" ··· 322 322 {{ $round := $item.RoundNumber }} 323 323 <div class="flex gap-2 items-center justify-between mb-1"> 324 324 <span class="inline-flex items-center gap-2 text-sm text-gray-500 dark:text-gray-400 pt-2"> 325 - {{ $handle := resolve $root.Pull.OwnerDid }} 325 + {{ $handle := resolve $root.Pull.OwnerDid }} 326 326 <a class="text-gray-500 dark:text-gray-400 hover:text-gray-500 dark:hover:text-gray-300" href="/{{ $handle }}">{{ $handle }}</a> 327 327 submitted 328 328 <span class="px-2 py-0.5 text-black dark:text-white bg-gray-100 dark:bg-gray-700 border-gray-300 dark:border-gray-600 rounded font-mono text-xs border">

History

2 rounds 4 comments
sign up or login to add to the discussion
eti.tf submitted #1
diff
1 commit
expand
016b2029
appview/pages/templates/repo/pulls: disable pointer events on "history" header
expand 0 comments
pull request successfully merged
eti.tf submitted #0
diff
1 commit
expand
de9c6ab1
appview/pages/templates/repo/pulls: disable pointer events on "history" header
expand 4 comments
oppi.li

appview/pages/templates/repo/pulls/pull.html:186: what does this pointer-events-auto here do?

eti.tf

it re-sets the pointer-events-none of the parent.
if we don't add pointer-events-auto on line 186 then there is no possibility for the user to select the text.
maybe they'd want to select the amount of rounds or the amount of comments to copy and paste them somewhere. i think this is a proper common behavior!

oppi.li

makes sense!

oppi.li

lgtm barring conflicts!