Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/v3d: fix a NULL vs error pointer mixup

The drm_gem_shmem_create() returns error pointers and v3d_bo_create() is
also supposed to return error pointers.

Fixes: 40609d4820b2 ("drm/v3d: Use the new shmem helpers to reduce driver boilerplate.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190321062731.GC21489@kadam

authored by

Dan Carpenter and committed by
Eric Anholt
fc0c77fc 181e5bf2

+2 -2
+2 -2
drivers/gpu/drm/v3d/v3d_bo.c
··· 130 130 int ret; 131 131 132 132 shmem_obj = drm_gem_shmem_create(dev, unaligned_size); 133 - if (!shmem_obj) 134 - return NULL; 133 + if (IS_ERR(shmem_obj)) 134 + return ERR_CAST(shmem_obj); 135 135 bo = to_v3d_bo(&shmem_obj->base); 136 136 137 137 ret = v3d_bo_create_finish(&shmem_obj->base);