Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8723bs: Remove function pointer intf_chip_configure

Remove function pointer intf_chip_configure and use
rtl8723bs_interface_configure directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/d542f172438c333c015b87376a20645eeeae1b99.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Philipp Hortmann and committed by
Greg Kroah-Hartman
f6faa9db 218fcc25

+3 -6
+1 -2
drivers/staging/rtl8723bs/hal/hal_intf.c
··· 9 9 10 10 void rtw_hal_chip_configure(struct adapter *padapter) 11 11 { 12 - if (padapter->HalFunc.intf_chip_configure) 13 - padapter->HalFunc.intf_chip_configure(padapter); 12 + rtl8723bs_interface_configure(padapter); 14 13 } 15 14 16 15 void rtw_hal_read_chip_info(struct adapter *padapter)
+1 -2
drivers/staging/rtl8723bs/hal/sdio_halinit.c
··· 950 950 pHalData->SdioRxFIFOCnt = 0; 951 951 } 952 952 953 - static void rtl8723bs_interface_configure(struct adapter *padapter) 953 + void rtl8723bs_interface_configure(struct adapter *padapter) 954 954 { 955 955 struct hal_com_data *pHalData = GET_HAL_DATA(padapter); 956 956 struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); ··· 1259 1259 1260 1260 rtl8723b_set_hal_ops(pHalFunc); 1261 1261 1262 - pHalFunc->intf_chip_configure = &rtl8723bs_interface_configure; 1263 1262 pHalFunc->read_adapter_info = &ReadAdapterInfo8723BS; 1264 1263 1265 1264 pHalFunc->enable_interrupt = &EnableInterrupt8723BSdio;
-2
drivers/staging/rtl8723bs/include/hal_intf.h
··· 162 162 typedef s32 (*c2h_id_filter)(u8 *c2h_evt); 163 163 164 164 struct hal_ops { 165 - void (*intf_chip_configure)(struct adapter *padapter); 166 - 167 165 void (*read_adapter_info)(struct adapter *padapter); 168 166 169 167 void (*enable_interrupt)(struct adapter *padapter);
+1
drivers/staging/rtl8723bs/include/rtl8723b_recv.h
··· 89 89 90 90 void rtl8723b_read_chip_version(struct adapter *padapter); 91 91 void rtl8723bs_init_default_value(struct adapter *padapter); 92 + void rtl8723bs_interface_configure(struct adapter *padapter); 92 93 93 94 #endif