Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8723bs: Remove function pointer init_default_value

Remove function pointer init_default_value and use
rtl8723bs_init_default_value directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/d0bb58235d54d1c7e4806c5ea3a50dbf77c293e7.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Philipp Hortmann and committed by
Greg Kroah-Hartman
218fcc25 484b521f

+3 -6
+1 -2
drivers/staging/rtl8723bs/hal/hal_intf.c
··· 26 26 27 27 void rtw_hal_def_value_init(struct adapter *padapter) 28 28 { 29 - if (padapter->HalFunc.init_default_value) 30 - padapter->HalFunc.init_default_value(padapter); 29 + rtl8723bs_init_default_value(padapter); 31 30 } 32 31 33 32 void rtw_hal_free_data(struct adapter *padapter)
+1 -2
drivers/staging/rtl8723bs/hal/sdio_halinit.c
··· 937 937 return _SUCCESS; 938 938 } 939 939 940 - static void rtl8723bs_init_default_value(struct adapter *padapter) 940 + void rtl8723bs_init_default_value(struct adapter *padapter) 941 941 { 942 942 struct hal_com_data *pHalData; 943 943 ··· 1259 1259 1260 1260 rtl8723b_set_hal_ops(pHalFunc); 1261 1261 1262 - pHalFunc->init_default_value = &rtl8723bs_init_default_value; 1263 1262 pHalFunc->intf_chip_configure = &rtl8723bs_interface_configure; 1264 1263 pHalFunc->read_adapter_info = &ReadAdapterInfo8723BS; 1265 1264
-2
drivers/staging/rtl8723bs/include/hal_intf.h
··· 162 162 typedef s32 (*c2h_id_filter)(u8 *c2h_evt); 163 163 164 164 struct hal_ops { 165 - void (*init_default_value)(struct adapter *padapter); 166 - 167 165 void (*intf_chip_configure)(struct adapter *padapter); 168 166 169 167 void (*read_adapter_info)(struct adapter *padapter);
+1
drivers/staging/rtl8723bs/include/rtl8723b_recv.h
··· 88 88 void rtl8723b_process_phy_info(struct adapter *padapter, void *prframe); 89 89 90 90 void rtl8723b_read_chip_version(struct adapter *padapter); 91 + void rtl8723bs_init_default_value(struct adapter *padapter); 91 92 92 93 #endif