Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: lp8788: Use devm_led_classdev_register

Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove platform_set_drvdata in probe function and the remove
function, lp8788_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

authored by

Amitoj Kaur Chawla and committed by
Jacek Anaszewski
f165a66e 375446df

+1 -13
+1 -13
drivers/leds/leds-lp8788.c
··· 146 146 147 147 mutex_init(&led->lock); 148 148 149 - platform_set_drvdata(pdev, led); 150 - 151 149 ret = lp8788_led_init_device(led, led_pdata); 152 150 if (ret) { 153 151 dev_err(dev, "led init device err: %d\n", ret); 154 152 return ret; 155 153 } 156 154 157 - ret = led_classdev_register(dev, &led->led_dev); 155 + ret = devm_led_classdev_register(dev, &led->led_dev); 158 156 if (ret) { 159 157 dev_err(dev, "led register err: %d\n", ret); 160 158 return ret; ··· 161 163 return 0; 162 164 } 163 165 164 - static int lp8788_led_remove(struct platform_device *pdev) 165 - { 166 - struct lp8788_led *led = platform_get_drvdata(pdev); 167 - 168 - led_classdev_unregister(&led->led_dev); 169 - 170 - return 0; 171 - } 172 - 173 166 static struct platform_driver lp8788_led_driver = { 174 167 .probe = lp8788_led_probe, 175 - .remove = lp8788_led_remove, 176 168 .driver = { 177 169 .name = LP8788_DEV_KEYLED, 178 170 },