Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: 88pm860x: Use devm_led_classdev_register

Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove platform_set_drvdata in probe function and the remove
function, pm860x_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

authored by

Amitoj Kaur Chawla and committed by
Jacek Anaszewski
375446df e0442d7d

+1 -11
+1 -11
drivers/leds/leds-88pm860x.c
··· 195 195 sprintf(data->name, "led1-blue"); 196 196 break; 197 197 } 198 - platform_set_drvdata(pdev, data); 199 198 data->chip = chip; 200 199 data->i2c = (chip->id == CHIP_PM8606) ? chip->client : chip->companion; 201 200 data->port = pdev->id; ··· 207 208 data->cdev.brightness_set_blocking = pm860x_led_set; 208 209 mutex_init(&data->lock); 209 210 210 - ret = led_classdev_register(chip->dev, &data->cdev); 211 + ret = devm_led_classdev_register(chip->dev, &data->cdev); 211 212 if (ret < 0) { 212 213 dev_err(&pdev->dev, "Failed to register LED: %d\n", ret); 213 214 return ret; ··· 216 217 return 0; 217 218 } 218 219 219 - static int pm860x_led_remove(struct platform_device *pdev) 220 - { 221 - struct pm860x_led *data = platform_get_drvdata(pdev); 222 - 223 - led_classdev_unregister(&data->cdev); 224 - 225 - return 0; 226 - } 227 220 228 221 static struct platform_driver pm860x_led_driver = { 229 222 .driver = { 230 223 .name = "88pm860x-led", 231 224 }, 232 225 .probe = pm860x_led_probe, 233 - .remove = pm860x_led_remove, 234 226 }; 235 227 236 228 module_platform_driver(pm860x_led_driver);