Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: ls037v7dw01: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104612.11516-1-caihuoqing@baidu.com

authored by

Cai Huoqing and committed by
Sam Ravnborg
ef41af47 a30fc787

+9 -12
+9 -12
drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
··· 146 146 lcd->pdev = pdev; 147 147 148 148 lcd->vdd = devm_regulator_get(&pdev->dev, "envdd"); 149 - if (IS_ERR(lcd->vdd)) { 150 - dev_err(&pdev->dev, "failed to get regulator\n"); 151 - return PTR_ERR(lcd->vdd); 152 - } 149 + if (IS_ERR(lcd->vdd)) 150 + return dev_err_probe(&pdev->dev, PTR_ERR(lcd->vdd), 151 + "failed to get regulator\n"); 153 152 154 153 lcd->ini_gpio = devm_gpiod_get(&pdev->dev, "enable", GPIOD_OUT_LOW); 155 - if (IS_ERR(lcd->ini_gpio)) { 156 - dev_err(&pdev->dev, "failed to get enable gpio\n"); 157 - return PTR_ERR(lcd->ini_gpio); 158 - } 154 + if (IS_ERR(lcd->ini_gpio)) 155 + return dev_err_probe(&pdev->dev, PTR_ERR(lcd->ini_gpio), 156 + "failed to get enable gpio\n"); 159 157 160 158 lcd->resb_gpio = devm_gpiod_get(&pdev->dev, "reset", GPIOD_OUT_LOW); 161 - if (IS_ERR(lcd->resb_gpio)) { 162 - dev_err(&pdev->dev, "failed to get reset gpio\n"); 163 - return PTR_ERR(lcd->resb_gpio); 164 - } 159 + if (IS_ERR(lcd->resb_gpio)) 160 + return dev_err_probe(&pdev->dev, PTR_ERR(lcd->resb_gpio), 161 + "failed to get reset gpio\n"); 165 162 166 163 lcd->mo_gpio = devm_gpiod_get_index(&pdev->dev, "mode", 0, 167 164 GPIOD_OUT_LOW);