Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: k101-im2ba02: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Icenowy Zheng <icenowy@aosc.io>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104247.11270-1-caihuoqing@baidu.com

authored by

Cai Huoqing and committed by
Sam Ravnborg
a30fc787 386e1c18

+5 -8
+5 -8
drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
··· 456 456 457 457 ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies), 458 458 ctx->supplies); 459 - if (ret < 0) { 460 - dev_err(&dsi->dev, "Couldn't get regulators\n"); 461 - return ret; 462 - } 459 + if (ret < 0) 460 + return dev_err_probe(&dsi->dev, ret, "Couldn't get regulators\n"); 463 461 464 462 ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); 465 - if (IS_ERR(ctx->reset)) { 466 - dev_err(&dsi->dev, "Couldn't get our reset GPIO\n"); 467 - return PTR_ERR(ctx->reset); 468 - } 463 + if (IS_ERR(ctx->reset)) 464 + return dev_err_probe(&dsi->dev, PTR_ERR(ctx->reset), 465 + "Couldn't get our reset GPIO\n"); 469 466 470 467 drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs, 471 468 DRM_MODE_CONNECTOR_DSI);