Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: mv: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231002080529.2535610-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Uwe Kleine-König and committed by
Alexandre Belloni
ede66fb3 482ca730

+2 -4
+2 -4
drivers/rtc/rtc-mv.c
··· 282 282 return ret; 283 283 } 284 284 285 - static int __exit mv_rtc_remove(struct platform_device *pdev) 285 + static void __exit mv_rtc_remove(struct platform_device *pdev) 286 286 { 287 287 struct rtc_plat_data *pdata = platform_get_drvdata(pdev); 288 288 ··· 291 291 292 292 if (!IS_ERR(pdata->clk)) 293 293 clk_disable_unprepare(pdata->clk); 294 - 295 - return 0; 296 294 } 297 295 298 296 #ifdef CONFIG_OF ··· 308 310 * triggering a section mismatch warning. 309 311 */ 310 312 static struct platform_driver mv_rtc_driver __refdata = { 311 - .remove = __exit_p(mv_rtc_remove), 313 + .remove_new = __exit_p(mv_rtc_remove), 312 314 .driver = { 313 315 .name = "rtc-mv", 314 316 .of_match_table = of_match_ptr(rtc_mv_of_match_table),