Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: imxdi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231002080529.2535610-10-u.kleine-koenig@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Uwe Kleine-König and committed by
Alexandre Belloni
482ca730 48bc8830

+2 -4
+2 -4
drivers/rtc/rtc-imxdi.c
··· 830 830 return rc; 831 831 } 832 832 833 - static int __exit dryice_rtc_remove(struct platform_device *pdev) 833 + static void __exit dryice_rtc_remove(struct platform_device *pdev) 834 834 { 835 835 struct imxdi_dev *imxdi = platform_get_drvdata(pdev); 836 836 ··· 840 840 writel(0, imxdi->ioaddr + DIER); 841 841 842 842 clk_disable_unprepare(imxdi->clk); 843 - 844 - return 0; 845 843 } 846 844 847 845 static const struct of_device_id dryice_dt_ids[] = { ··· 860 862 .name = "imxdi_rtc", 861 863 .of_match_table = dryice_dt_ids, 862 864 }, 863 - .remove = __exit_p(dryice_rtc_remove), 865 + .remove_new = __exit_p(dryice_rtc_remove), 864 866 }; 865 867 866 868 module_platform_driver_probe(dryice_rtc_driver, dryice_rtc_probe);