Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: sprd: Add macros for referencing parents without strings

With the new clk parenting code, clk_init_data was expanded to include
.parent_hws and .parent_data, for clk drivers to specify parents without
name strings of clocks.

Also some macros were added for using these two items to reference
clock parents. Based on that to expand macros for sprd clocks:

- SPRD_*_DATA, take an array of struct clk_parent_data * as its parents
which should be a combination of .fw_name (devicetree clock-names),
.hw (pointers to a local struct clk_hw).

- SPRD_*_HW, take a local struct clk_hw pointer, instead of a string, as
its parent.

- SPRD_*_FW_NAME, take a string of clock-names decleared in the device
tree as the clock parent.

Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Link: https://lkml.kernel.org/r/20200304072730.9193-6-zhang.lyra@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Chunyan Zhang and committed by
Stephen Boyd
ea8ca310 be7ef655

+196 -55
+28 -11
drivers/clk/sprd/composite.h
··· 18 18 struct sprd_clk_common common; 19 19 }; 20 20 21 - #define SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, _table, \ 22 - _mshift, _mwidth, _dshift, _dwidth, _flags) \ 21 + #define SPRD_COMP_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, _table, \ 22 + _mshift, _mwidth, _dshift, _dwidth, \ 23 + _flags, _fn) \ 23 24 struct sprd_comp _struct = { \ 24 25 .mux = _SPRD_MUX_CLK(_mshift, _mwidth, _table), \ 25 26 .div = _SPRD_DIV_CLK(_dshift, _dwidth), \ 26 27 .common = { \ 27 28 .regmap = NULL, \ 28 29 .reg = _reg, \ 29 - .hw.init = CLK_HW_INIT_PARENTS(_name, \ 30 - _parent, \ 31 - &sprd_comp_ops, \ 32 - _flags), \ 30 + .hw.init = _fn(_name, _parent, \ 31 + &sprd_comp_ops, _flags), \ 33 32 } \ 34 33 } 35 34 36 - #define SPRD_COMP_CLK(_struct, _name, _parent, _reg, _mshift, \ 37 - _mwidth, _dshift, _dwidth, _flags) \ 38 - SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, \ 39 - NULL, _mshift, _mwidth, \ 40 - _dshift, _dwidth, _flags) 35 + #define SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, _table, \ 36 + _mshift, _mwidth, _dshift, _dwidth, _flags) \ 37 + SPRD_COMP_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, _table, \ 38 + _mshift, _mwidth, _dshift, _dwidth, \ 39 + _flags, CLK_HW_INIT_PARENTS) 40 + 41 + #define SPRD_COMP_CLK(_struct, _name, _parent, _reg, _mshift, \ 42 + _mwidth, _dshift, _dwidth, _flags) \ 43 + SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, NULL, \ 44 + _mshift, _mwidth, _dshift, _dwidth, _flags) 45 + 46 + #define SPRD_COMP_CLK_DATA_TABLE(_struct, _name, _parent, _reg, _table, \ 47 + _mshift, _mwidth, _dshift, \ 48 + _dwidth, _flags) \ 49 + SPRD_COMP_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, _table, \ 50 + _mshift, _mwidth, _dshift, _dwidth, \ 51 + _flags, CLK_HW_INIT_PARENTS_DATA) 52 + 53 + #define SPRD_COMP_CLK_DATA(_struct, _name, _parent, _reg, _mshift, \ 54 + _mwidth, _dshift, _dwidth, _flags) \ 55 + SPRD_COMP_CLK_DATA_TABLE(_struct, _name, _parent, _reg, NULL, \ 56 + _mshift, _mwidth, _dshift, _dwidth, \ 57 + _flags) 41 58 42 59 static inline struct sprd_comp *hw_to_sprd_comp(const struct clk_hw *hw) 43 60 {
+14 -6
drivers/clk/sprd/div.h
··· 35 35 struct sprd_clk_common common; 36 36 }; 37 37 38 - #define SPRD_DIV_CLK(_struct, _name, _parent, _reg, \ 39 - _shift, _width, _flags) \ 38 + #define SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 39 + _shift, _width, _flags, _fn) \ 40 40 struct sprd_div _struct = { \ 41 41 .div = _SPRD_DIV_CLK(_shift, _width), \ 42 42 .common = { \ 43 43 .regmap = NULL, \ 44 44 .reg = _reg, \ 45 - .hw.init = CLK_HW_INIT(_name, \ 46 - _parent, \ 47 - &sprd_div_ops, \ 48 - _flags), \ 45 + .hw.init = _fn(_name, _parent, \ 46 + &sprd_div_ops, _flags), \ 49 47 } \ 50 48 } 49 + 50 + #define SPRD_DIV_CLK(_struct, _name, _parent, _reg, \ 51 + _shift, _width, _flags) \ 52 + SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 53 + _shift, _width, _flags, CLK_HW_INIT) 54 + 55 + #define SPRD_DIV_CLK_HW(_struct, _name, _parent, _reg, \ 56 + _shift, _width, _flags) \ 57 + SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 58 + _shift, _width, _flags, CLK_HW_INIT_HW) 51 59 52 60 static inline struct sprd_div *hw_to_sprd_div(const struct clk_hw *hw) 53 61 {
+96 -13
drivers/clk/sprd/gate.h
··· 19 19 struct sprd_clk_common common; 20 20 }; 21 21 22 - #define SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg, \ 22 + #define SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 23 23 _sc_offset, _enable_mask, _flags, \ 24 - _gate_flags, _udelay, _ops) \ 24 + _gate_flags, _udelay, _ops, _fn) \ 25 25 struct sprd_gate _struct = { \ 26 26 .enable_mask = _enable_mask, \ 27 27 .sc_offset = _sc_offset, \ ··· 30 30 .common = { \ 31 31 .regmap = NULL, \ 32 32 .reg = _reg, \ 33 - .hw.init = CLK_HW_INIT(_name, \ 34 - _parent, \ 35 - _ops, \ 36 - _flags), \ 33 + .hw.init = _fn(_name, _parent, \ 34 + _ops, _flags), \ 37 35 } \ 38 36 } 37 + 38 + #define SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg, \ 39 + _sc_offset, _enable_mask, _flags, \ 40 + _gate_flags, _udelay, _ops) \ 41 + SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 42 + _sc_offset, _enable_mask, _flags, \ 43 + _gate_flags, _udelay, _ops, CLK_HW_INIT) 39 44 40 45 #define SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, _sc_offset, \ 41 46 _enable_mask, _flags, _gate_flags, _ops) \ ··· 48 43 _sc_offset, _enable_mask, _flags, \ 49 44 _gate_flags, 0, _ops) 50 45 51 - #define SPRD_GATE_CLK(_struct, _name, _parent, _reg, \ 52 - _enable_mask, _flags, _gate_flags) \ 53 - SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, 0, \ 54 - _enable_mask, _flags, _gate_flags, \ 55 - &sprd_gate_ops) 56 - 57 46 #define SPRD_SC_GATE_CLK(_struct, _name, _parent, _reg, _sc_offset, \ 58 47 _enable_mask, _flags, _gate_flags) \ 59 48 SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, _sc_offset, \ 60 49 _enable_mask, _flags, _gate_flags, \ 61 50 &sprd_sc_gate_ops) 62 51 52 + #define SPRD_GATE_CLK(_struct, _name, _parent, _reg, \ 53 + _enable_mask, _flags, _gate_flags) \ 54 + SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, 0, \ 55 + _enable_mask, _flags, _gate_flags, \ 56 + &sprd_gate_ops) 57 + 63 58 #define SPRD_PLL_SC_GATE_CLK(_struct, _name, _parent, _reg, _sc_offset, \ 64 - _enable_mask, _flags, _gate_flags, _udelay) \ 59 + _enable_mask, _flags, _gate_flags, \ 60 + _udelay) \ 65 61 SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg, \ 66 62 _sc_offset, _enable_mask, _flags, \ 67 63 _gate_flags, _udelay, \ 68 64 &sprd_pll_sc_gate_ops) 65 + 66 + 67 + #define SPRD_SC_GATE_CLK_HW_OPS_UDELAY(_struct, _name, _parent, _reg, \ 68 + _sc_offset, _enable_mask, \ 69 + _flags, _gate_flags, \ 70 + _udelay, _ops) \ 71 + SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 72 + _sc_offset, _enable_mask, _flags, \ 73 + _gate_flags, _udelay, _ops, \ 74 + CLK_HW_INIT_HW) 75 + 76 + #define SPRD_SC_GATE_CLK_HW_OPS(_struct, _name, _parent, _reg, \ 77 + _sc_offset, _enable_mask, _flags, \ 78 + _gate_flags, _ops) \ 79 + SPRD_SC_GATE_CLK_HW_OPS_UDELAY(_struct, _name, _parent, _reg, \ 80 + _sc_offset, _enable_mask, \ 81 + _flags, _gate_flags, 0, _ops) 82 + 83 + #define SPRD_SC_GATE_CLK_HW(_struct, _name, _parent, _reg, \ 84 + _sc_offset, _enable_mask, _flags, \ 85 + _gate_flags) \ 86 + SPRD_SC_GATE_CLK_HW_OPS(_struct, _name, _parent, _reg, \ 87 + _sc_offset, _enable_mask, _flags, \ 88 + _gate_flags, &sprd_sc_gate_ops) 89 + 90 + #define SPRD_GATE_CLK_HW(_struct, _name, _parent, _reg, \ 91 + _enable_mask, _flags, _gate_flags) \ 92 + SPRD_SC_GATE_CLK_HW_OPS(_struct, _name, _parent, _reg, 0, \ 93 + _enable_mask, _flags, _gate_flags, \ 94 + &sprd_gate_ops) 95 + 96 + #define SPRD_PLL_SC_GATE_CLK_HW(_struct, _name, _parent, _reg, \ 97 + _sc_offset, _enable_mask, _flags, \ 98 + _gate_flags, _udelay) \ 99 + SPRD_SC_GATE_CLK_HW_OPS_UDELAY(_struct, _name, _parent, _reg, \ 100 + _sc_offset, _enable_mask, \ 101 + _flags, _gate_flags, _udelay, \ 102 + &sprd_pll_sc_gate_ops) 103 + 104 + #define SPRD_SC_GATE_CLK_FW_NAME_OPS_UDELAY(_struct, _name, _parent, \ 105 + _reg, _sc_offset, \ 106 + _enable_mask, _flags, \ 107 + _gate_flags, _udelay, _ops) \ 108 + SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, \ 109 + _sc_offset, _enable_mask, _flags, \ 110 + _gate_flags, _udelay, _ops, \ 111 + CLK_HW_INIT_FW_NAME) 112 + 113 + #define SPRD_SC_GATE_CLK_FW_NAME_OPS(_struct, _name, _parent, _reg, \ 114 + _sc_offset, _enable_mask, _flags, \ 115 + _gate_flags, _ops) \ 116 + SPRD_SC_GATE_CLK_FW_NAME_OPS_UDELAY(_struct, _name, _parent, \ 117 + _reg, _sc_offset, \ 118 + _enable_mask, _flags, \ 119 + _gate_flags, 0, _ops) 120 + 121 + #define SPRD_SC_GATE_CLK_FW_NAME(_struct, _name, _parent, _reg, \ 122 + _sc_offset, _enable_mask, _flags, \ 123 + _gate_flags) \ 124 + SPRD_SC_GATE_CLK_FW_NAME_OPS(_struct, _name, _parent, _reg, \ 125 + _sc_offset, _enable_mask, _flags, \ 126 + _gate_flags, &sprd_sc_gate_ops) 127 + 128 + #define SPRD_GATE_CLK_FW_NAME(_struct, _name, _parent, _reg, \ 129 + _enable_mask, _flags, _gate_flags) \ 130 + SPRD_SC_GATE_CLK_FW_NAME_OPS(_struct, _name, _parent, _reg, 0, \ 131 + _enable_mask, _flags, _gate_flags, \ 132 + &sprd_gate_ops) 133 + 134 + #define SPRD_PLL_SC_GATE_CLK_FW_NAME(_struct, _name, _parent, _reg, \ 135 + _sc_offset, _enable_mask, _flags, \ 136 + _gate_flags, _udelay) \ 137 + SPRD_SC_GATE_CLK_FW_NAME_OPS_UDELAY(_struct, _name, _parent, \ 138 + _reg, _sc_offset, \ 139 + _enable_mask, _flags, \ 140 + _gate_flags, _udelay, \ 141 + &sprd_pll_sc_gate_ops) 69 142 70 143 static inline struct sprd_gate *hw_to_sprd_gate(const struct clk_hw *hw) 71 144 {
+21 -7
drivers/clk/sprd/mux.h
··· 36 36 .table = _table, \ 37 37 } 38 38 39 - #define SPRD_MUX_CLK_TABLE(_struct, _name, _parents, _table, \ 40 - _reg, _shift, _width, \ 41 - _flags) \ 39 + #define SPRD_MUX_CLK_HW_INIT_FN(_struct, _name, _parents, _table, \ 40 + _reg, _shift, _width, _flags, _fn) \ 42 41 struct sprd_mux _struct = { \ 43 42 .mux = _SPRD_MUX_CLK(_shift, _width, _table), \ 44 43 .common = { \ 45 44 .regmap = NULL, \ 46 45 .reg = _reg, \ 47 - .hw.init = CLK_HW_INIT_PARENTS(_name, \ 48 - _parents, \ 49 - &sprd_mux_ops, \ 50 - _flags), \ 46 + .hw.init = _fn(_name, _parents, \ 47 + &sprd_mux_ops, _flags), \ 51 48 } \ 52 49 } 50 + 51 + #define SPRD_MUX_CLK_TABLE(_struct, _name, _parents, _table, \ 52 + _reg, _shift, _width, _flags) \ 53 + SPRD_MUX_CLK_HW_INIT_FN(_struct, _name, _parents, _table, \ 54 + _reg, _shift, _width, _flags, \ 55 + CLK_HW_INIT_PARENTS) 53 56 54 57 #define SPRD_MUX_CLK(_struct, _name, _parents, _reg, \ 55 58 _shift, _width, _flags) \ 56 59 SPRD_MUX_CLK_TABLE(_struct, _name, _parents, NULL, \ 57 60 _reg, _shift, _width, _flags) 61 + 62 + #define SPRD_MUX_CLK_DATA_TABLE(_struct, _name, _parents, _table, \ 63 + _reg, _shift, _width, _flags) \ 64 + SPRD_MUX_CLK_HW_INIT_FN(_struct, _name, _parents, _table, \ 65 + _reg, _shift, _width, _flags, \ 66 + CLK_HW_INIT_PARENTS_DATA) 67 + 68 + #define SPRD_MUX_CLK_DATA(_struct, _name, _parents, _reg, \ 69 + _shift, _width, _flags) \ 70 + SPRD_MUX_CLK_DATA_TABLE(_struct, _name, _parents, NULL, \ 71 + _reg, _shift, _width, _flags) 58 72 59 73 static inline struct sprd_mux *hw_to_sprd_mux(const struct clk_hw *hw) 60 74 {
+37 -18
drivers/clk/sprd/pll.h
··· 61 61 struct sprd_clk_common common; 62 62 }; 63 63 64 + #define SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, \ 65 + _regs_num, _itable, _factors, \ 66 + _udelay, _k1, _k2, _fflag, \ 67 + _fvco, _fn) \ 68 + struct sprd_pll _struct = { \ 69 + .regs_num = _regs_num, \ 70 + .itable = _itable, \ 71 + .factors = _factors, \ 72 + .udelay = _udelay, \ 73 + .k1 = _k1, \ 74 + .k2 = _k2, \ 75 + .fflag = _fflag, \ 76 + .fvco = _fvco, \ 77 + .common = { \ 78 + .regmap = NULL, \ 79 + .reg = _reg, \ 80 + .hw.init = _fn(_name, _parent, \ 81 + &sprd_pll_ops, 0),\ 82 + }, \ 83 + } 84 + 64 85 #define SPRD_PLL_WITH_ITABLE_K_FVCO(_struct, _name, _parent, _reg, \ 65 86 _regs_num, _itable, _factors, \ 66 87 _udelay, _k1, _k2, _fflag, _fvco) \ 67 - struct sprd_pll _struct = { \ 68 - .regs_num = _regs_num, \ 69 - .itable = _itable, \ 70 - .factors = _factors, \ 71 - .udelay = _udelay, \ 72 - .k1 = _k1, \ 73 - .k2 = _k2, \ 74 - .fflag = _fflag, \ 75 - .fvco = _fvco, \ 76 - .common = { \ 77 - .regmap = NULL, \ 78 - .reg = _reg, \ 79 - .hw.init = CLK_HW_INIT(_name, \ 80 - _parent, \ 81 - &sprd_pll_ops, \ 82 - 0), \ 83 - }, \ 84 - } 88 + SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, _regs_num, \ 89 + _itable, _factors, _udelay, _k1, _k2, \ 90 + _fflag, _fvco, CLK_HW_INIT) 85 91 86 92 #define SPRD_PLL_WITH_ITABLE_K(_struct, _name, _parent, _reg, \ 87 93 _regs_num, _itable, _factors, \ ··· 101 95 SPRD_PLL_WITH_ITABLE_K_FVCO(_struct, _name, _parent, _reg, \ 102 96 _regs_num, _itable, _factors, \ 103 97 _udelay, 1000, 1000, 0, 0) 98 + 99 + #define SPRD_PLL_FW_NAME(_struct, _name, _parent, _reg, _regs_num, \ 100 + _itable, _factors, _udelay, _k1, _k2, \ 101 + _fflag, _fvco) \ 102 + SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, _regs_num, \ 103 + _itable, _factors, _udelay, _k1, _k2, \ 104 + _fflag, _fvco, CLK_HW_INIT_FW_NAME) 105 + 106 + #define SPRD_PLL_HW(_struct, _name, _parent, _reg, _regs_num, _itable, \ 107 + _factors, _udelay, _k1, _k2, _fflag, _fvco) \ 108 + SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, _regs_num, \ 109 + _itable, _factors, _udelay, _k1, _k2, \ 110 + _fflag, _fvco, CLK_HW_INIT_HW) 104 111 105 112 static inline struct sprd_pll *hw_to_sprd_pll(struct clk_hw *hw) 106 113 {