Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/sti: Replace 17 seq_puts() calls by seq_putc()

Single characters should be put into a sequence at several places.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: http://patchwork.freedesktop.org/patch/msgid/5b4e2964-0742-8367-976f-678356d9347a@users.sourceforge.net

authored by

Markus Elfring and committed by
Benjamin Gaignard
e9635133 ecf79d15

+17 -25
+1 -2
drivers/gpu/drm/sti/sti_cursor.c
··· 121 121 cursor_dbg_cml(s, cursor, readl(cursor->regs + CUR_CML)); 122 122 DBGFS_DUMP(CUR_AWS); 123 123 DBGFS_DUMP(CUR_AWE); 124 - seq_puts(s, "\n"); 125 - 124 + seq_putc(s, '\n'); 126 125 return 0; 127 126 } 128 127
+1 -2
drivers/gpu/drm/sti/sti_dvo.c
··· 186 186 DBGFS_DUMP(DVO_LUT_PROG_MID); 187 187 DBGFS_DUMP(DVO_LUT_PROG_HIGH); 188 188 dvo_dbg_awg_microcode(s, dvo->regs + DVO_DIGSYNC_INSTR_I); 189 - seq_puts(s, "\n"); 190 - 189 + seq_putc(s, '\n'); 191 190 return 0; 192 191 } 193 192
+1 -2
drivers/gpu/drm/sti/sti_hda.c
··· 354 354 hda_dbg_awg_microcode(s, hda->regs + HDA_SYNC_AWGI); 355 355 if (hda->video_dacs_ctrl) 356 356 hda_dbg_video_dacs_ctrl(s, hda->video_dacs_ctrl); 357 - seq_puts(s, "\n"); 358 - 357 + seq_putc(s, '\n'); 359 358 return 0; 360 359 } 361 360
+8 -9
drivers/gpu/drm/sti/sti_hdmi.c
··· 592 592 { 593 593 int tmp; 594 594 595 - seq_puts(s, "\t"); 595 + seq_putc(s, '\t'); 596 596 tmp = val & HDMI_CFG_HDMI_NOT_DVI; 597 597 DBGFS_PRINT_STR("mode:", tmp ? "HDMI" : "DVI"); 598 598 seq_puts(s, "\t\t\t\t\t"); ··· 616 616 { 617 617 int tmp; 618 618 619 - seq_puts(s, "\t"); 619 + seq_putc(s, '\t'); 620 620 tmp = (val & HDMI_STA_DLL_LCK); 621 621 DBGFS_PRINT_STR("pll:", tmp ? "locked" : "not locked"); 622 622 seq_puts(s, "\t\t\t\t\t"); ··· 632 632 "once every field", 633 633 "once every frame"}; 634 634 635 - seq_puts(s, "\t"); 635 + seq_putc(s, '\t'); 636 636 tmp = (val & HDMI_IFRAME_CFG_DI_N(HDMI_IFRAME_MASK, 1)); 637 637 DBGFS_PRINT_STR("Data island 1:", en_di[tmp]); 638 638 seq_puts(s, "\t\t\t\t\t"); ··· 664 664 DBGFS_DUMP("\n", HDMI_STA); 665 665 hdmi_dbg_sta(s, hdmi_read(hdmi, HDMI_STA)); 666 666 DBGFS_DUMP("", HDMI_ACTIVE_VID_XMIN); 667 - seq_puts(s, "\t"); 667 + seq_putc(s, '\t'); 668 668 DBGFS_PRINT_INT("Xmin:", hdmi_read(hdmi, HDMI_ACTIVE_VID_XMIN)); 669 669 DBGFS_DUMP("", HDMI_ACTIVE_VID_XMAX); 670 - seq_puts(s, "\t"); 670 + seq_putc(s, '\t'); 671 671 DBGFS_PRINT_INT("Xmax:", hdmi_read(hdmi, HDMI_ACTIVE_VID_XMAX)); 672 672 DBGFS_DUMP("", HDMI_ACTIVE_VID_YMIN); 673 - seq_puts(s, "\t"); 673 + seq_putc(s, '\t'); 674 674 DBGFS_PRINT_INT("Ymin:", hdmi_read(hdmi, HDMI_ACTIVE_VID_YMIN)); 675 675 DBGFS_DUMP("", HDMI_ACTIVE_VID_YMAX); 676 - seq_puts(s, "\t"); 676 + seq_putc(s, '\t'); 677 677 DBGFS_PRINT_INT("Ymax:", hdmi_read(hdmi, HDMI_ACTIVE_VID_YMAX)); 678 678 DBGFS_DUMP("", HDMI_SW_DI_CFG); 679 679 hdmi_dbg_sw_di_cfg(s, hdmi_read(hdmi, HDMI_SW_DI_CFG)); ··· 712 712 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_VENDOR); 713 713 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_VENDOR); 714 714 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_VENDOR); 715 - seq_puts(s, "\n"); 716 - 715 + seq_putc(s, '\n'); 717 716 return 0; 718 717 } 719 718
+1 -2
drivers/gpu/drm/sti/sti_hqvdp.c
··· 625 625 hqvdp_dbg_dump_cmd(s, (struct sti_hqvdp_cmd *)virt); 626 626 } 627 627 628 - seq_puts(s, "\n"); 629 - 628 + seq_putc(s, '\n'); 630 629 return 0; 631 630 } 632 631
+1 -2
drivers/gpu/drm/sti/sti_mixer.c
··· 162 162 DBGFS_DUMP(GAM_MIXER_MBP); 163 163 DBGFS_DUMP(GAM_MIXER_MX0); 164 164 mixer_dbg_mxn(s, mixer->regs + GAM_MIXER_MX0); 165 - seq_puts(s, "\n"); 166 - 165 + seq_putc(s, '\n'); 167 166 return 0; 168 167 } 169 168
+2 -3
drivers/gpu/drm/sti/sti_tvout.c
··· 459 459 "Aux (color matrix by-passed)", 460 460 "", "", "", "", "", "Force value"}; 461 461 462 - seq_puts(s, "\t"); 462 + seq_putc(s, '\t'); 463 463 mask = TVO_VIP_REORDER_MASK << TVO_VIP_REORDER_R_SHIFT; 464 464 r = (val & mask) >> TVO_VIP_REORDER_R_SHIFT; 465 465 mask = TVO_VIP_REORDER_MASK << TVO_VIP_REORDER_G_SHIFT; ··· 558 558 DBGFS_DUMP(TVO_CSC_AUX_M6); 559 559 DBGFS_DUMP(TVO_CSC_AUX_M7); 560 560 DBGFS_DUMP(TVO_AUX_IN_VID_FORMAT); 561 - seq_puts(s, "\n"); 562 - 561 + seq_putc(s, '\n'); 563 562 return 0; 564 563 } 565 564
+2 -3
drivers/gpu/drm/sti/sti_vid.c
··· 61 61 static void vid_dbg_ctl(struct seq_file *s, int val) 62 62 { 63 63 val = val >> 30; 64 - seq_puts(s, "\t"); 64 + seq_putc(s, '\t'); 65 65 66 66 if (!(val & 1)) 67 67 seq_puts(s, "NOT "); ··· 114 114 DBGFS_DUMP(VID_BC); 115 115 DBGFS_DUMP(VID_TINT); 116 116 DBGFS_DUMP(VID_CSAT); 117 - seq_puts(s, "\n"); 118 - 117 + seq_putc(s, '\n'); 119 118 return 0; 120 119 } 121 120