Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/sti: Reduce function calls for sequence output at five places

Some data were put into a sequence by separate function calls.
Print the same data by five single function calls instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1f5c5b0d-77c4-6efc-7906-cee76c33d2b0@users.sourceforge.net

authored by

Markus Elfring and committed by
Benjamin Gaignard
ecf79d15 adea1db2

+5 -10
+1 -2
drivers/gpu/drm/sti/sti_gdp.c
··· 266 266 seq_printf(s, "\n\tKEY2 0x%08X", node->gam_gdp_key2); 267 267 seq_printf(s, "\n\tPPT 0x%08X", node->gam_gdp_ppt); 268 268 gdp_dbg_ppt(s, node->gam_gdp_ppt); 269 - seq_printf(s, "\n\tCML 0x%08X", node->gam_gdp_cml); 270 - seq_puts(s, "\n"); 269 + seq_printf(s, "\n\tCML 0x%08X\n", node->gam_gdp_cml); 271 270 } 272 271 273 272 static int gdp_node_dbg_show(struct seq_file *s, void *arg)
+2 -4
drivers/gpu/drm/sti/sti_hda.c
··· 320 320 { 321 321 unsigned int i; 322 322 323 - seq_puts(s, "\n\n"); 324 - seq_puts(s, " HDA AWG microcode:"); 323 + seq_puts(s, "\n\n HDA AWG microcode:"); 325 324 for (i = 0; i < AWG_MAX_INST; i++) { 326 325 if (i % 8 == 0) 327 326 seq_printf(s, "\n %04X:", i); ··· 332 333 { 333 334 u32 val = readl(reg); 334 335 335 - seq_puts(s, "\n"); 336 - seq_printf(s, "\n %-25s 0x%08X", "VIDEO_DACS_CONTROL", val); 336 + seq_printf(s, "\n\n %-25s 0x%08X", "VIDEO_DACS_CONTROL", val); 337 337 seq_puts(s, "\tHD DACs "); 338 338 seq_puts(s, val & DAC_CFG_HD_HZUVW_OFF_MASK ? "disabled" : "enabled"); 339 339 }
+2 -4
drivers/gpu/drm/sti/sti_hdmi.c
··· 692 692 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_AVI); 693 693 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_AVI); 694 694 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_AVI); 695 - seq_puts(s, "\n"); 696 - seq_printf(s, "\n AUDIO Infoframe (Data Island slot N=%d):", 695 + seq_printf(s, "\n\n AUDIO Infoframe (Data Island slot N=%d):", 697 696 HDMI_IFRAME_SLOT_AUDIO); 698 697 DBGFS_DUMP_DI(HDMI_SW_DI_N_HEAD_WORD, HDMI_IFRAME_SLOT_AUDIO); 699 698 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD0, HDMI_IFRAME_SLOT_AUDIO); ··· 702 703 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD4, HDMI_IFRAME_SLOT_AUDIO); 703 704 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD5, HDMI_IFRAME_SLOT_AUDIO); 704 705 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_AUDIO); 705 - seq_puts(s, "\n"); 706 - seq_printf(s, "\n VENDOR SPECIFIC Infoframe (Data Island slot N=%d):", 706 + seq_printf(s, "\n\n VENDOR SPECIFIC Infoframe (Data Island slot N=%d):", 707 707 HDMI_IFRAME_SLOT_VENDOR); 708 708 DBGFS_DUMP_DI(HDMI_SW_DI_N_HEAD_WORD, HDMI_IFRAME_SLOT_VENDOR); 709 709 DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD0, HDMI_IFRAME_SLOT_VENDOR);