Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tegra: plane: Improve use of dev_err_probe()

Return dev_err_probe() directly, because the return value of
dev_err_probe() is the appropriate error code, and it can
reduce code size, simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

authored by

Cai Huoqing and committed by
Thierry Reding
e752eef0 fc75e4fc

+6 -10
+6 -10
drivers/gpu/drm/tegra/plane.c
··· 777 777 778 778 plane->icc_mem = devm_of_icc_get(dev, icc_name); 779 779 err = PTR_ERR_OR_ZERO(plane->icc_mem); 780 - if (err) { 781 - dev_err_probe(dev, err, "failed to get %s interconnect\n", 782 - icc_name); 783 - return err; 784 - } 780 + if (err) 781 + return dev_err_probe(dev, err, "failed to get %s interconnect\n", 782 + icc_name); 785 783 786 784 /* plane B on T20/30 has a dedicated memory client for a 6-tap vertical filter */ 787 785 if (plane->index == 1 && dc->soc->has_win_b_vfilter_mem_client) { 788 786 plane->icc_mem_vfilter = devm_of_icc_get(dev, "winb-vfilter"); 789 787 err = PTR_ERR_OR_ZERO(plane->icc_mem_vfilter); 790 - if (err) { 791 - dev_err_probe(dev, err, "failed to get %s interconnect\n", 792 - "winb-vfilter"); 793 - return err; 794 - } 788 + if (err) 789 + return dev_err_probe(dev, err, "failed to get %s interconnect\n", 790 + "winb-vfilter"); 795 791 } 796 792 797 793 return 0;