Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tegra: dsi: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

authored by

Cai Huoqing and committed by
Thierry Reding
fc75e4fc d4281c01

+12 -16
+12 -16
drivers/gpu/drm/tegra/dsi.c
··· 1589 1589 } 1590 1590 1591 1591 dsi->clk = devm_clk_get(&pdev->dev, NULL); 1592 - if (IS_ERR(dsi->clk)) { 1593 - dev_err(&pdev->dev, "cannot get DSI clock\n"); 1594 - return PTR_ERR(dsi->clk); 1595 - } 1592 + if (IS_ERR(dsi->clk)) 1593 + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk), 1594 + "cannot get DSI clock\n"); 1596 1595 1597 1596 dsi->clk_lp = devm_clk_get(&pdev->dev, "lp"); 1598 - if (IS_ERR(dsi->clk_lp)) { 1599 - dev_err(&pdev->dev, "cannot get low-power clock\n"); 1600 - return PTR_ERR(dsi->clk_lp); 1601 - } 1597 + if (IS_ERR(dsi->clk_lp)) 1598 + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_lp), 1599 + "cannot get low-power clock\n"); 1602 1600 1603 1601 dsi->clk_parent = devm_clk_get(&pdev->dev, "parent"); 1604 - if (IS_ERR(dsi->clk_parent)) { 1605 - dev_err(&pdev->dev, "cannot get parent clock\n"); 1606 - return PTR_ERR(dsi->clk_parent); 1607 - } 1602 + if (IS_ERR(dsi->clk_parent)) 1603 + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_parent), 1604 + "cannot get parent clock\n"); 1608 1605 1609 1606 dsi->vdd = devm_regulator_get(&pdev->dev, "avdd-dsi-csi"); 1610 - if (IS_ERR(dsi->vdd)) { 1611 - dev_err(&pdev->dev, "cannot get VDD supply\n"); 1612 - return PTR_ERR(dsi->vdd); 1613 - } 1607 + if (IS_ERR(dsi->vdd)) 1608 + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->vdd), 1609 + "cannot get VDD supply\n"); 1614 1610 1615 1611 err = tegra_dsi_setup_clocks(dsi); 1616 1612 if (err < 0) {