Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: pwm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-14-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Uwe Kleine-König and committed by
Stephen Boyd
e72cdad5 8ffd6c28

+2 -4
+2 -4
drivers/clk/clk-pwm.c
··· 129 129 return of_clk_add_hw_provider(node, of_clk_hw_simple_get, &clk_pwm->hw); 130 130 } 131 131 132 - static int clk_pwm_remove(struct platform_device *pdev) 132 + static void clk_pwm_remove(struct platform_device *pdev) 133 133 { 134 134 of_clk_del_provider(pdev->dev.of_node); 135 - 136 - return 0; 137 135 } 138 136 139 137 static const struct of_device_id clk_pwm_dt_ids[] = { ··· 142 144 143 145 static struct platform_driver clk_pwm_driver = { 144 146 .probe = clk_pwm_probe, 145 - .remove = clk_pwm_remove, 147 + .remove_new = clk_pwm_remove, 146 148 .driver = { 147 149 .name = "pwm-clock", 148 150 .of_match_table = clk_pwm_dt_ids,