Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: palmas: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Uwe Kleine-König and committed by
Stephen Boyd
8ffd6c28 601b2f14

+2 -3
+2 -3
drivers/clk/clk-palmas.c
··· 271 271 return ret; 272 272 } 273 273 274 - static int palmas_clks_remove(struct platform_device *pdev) 274 + static void palmas_clks_remove(struct platform_device *pdev) 275 275 { 276 276 of_clk_del_provider(pdev->dev.of_node); 277 - return 0; 278 277 } 279 278 280 279 static struct platform_driver palmas_clks_driver = { ··· 282 283 .of_match_table = palmas_clks_of_match, 283 284 }, 284 285 .probe = palmas_clks_probe, 285 - .remove = palmas_clks_remove, 286 + .remove_new = palmas_clks_remove, 286 287 }; 287 288 288 289 module_platform_driver(palmas_clks_driver);