Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: sh: aica: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
de0f49b8 c3d8cb19

+2 -3
+2 -3
sound/sh/aica.c
··· 539 539 return 0; 540 540 } 541 541 542 - static int snd_aica_remove(struct platform_device *devptr) 542 + static void snd_aica_remove(struct platform_device *devptr) 543 543 { 544 544 struct snd_card_aica *dreamcastcard; 545 545 dreamcastcard = platform_get_drvdata(devptr); 546 546 snd_card_free(dreamcastcard->card); 547 547 kfree(dreamcastcard); 548 - return 0; 549 548 } 550 549 551 550 static int snd_aica_probe(struct platform_device *devptr) ··· 591 592 592 593 static struct platform_driver snd_aica_driver = { 593 594 .probe = snd_aica_probe, 594 - .remove = snd_aica_remove, 595 + .remove_new = snd_aica_remove, 595 596 .driver = { 596 597 .name = SND_AICA_DRIVER, 597 598 },