Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: ppc/powermac: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
c3d8cb19 d8a3441b

+2 -3
+2 -3
sound/ppc/powermac.c
··· 130 130 } 131 131 132 132 133 - static int snd_pmac_remove(struct platform_device *devptr) 133 + static void snd_pmac_remove(struct platform_device *devptr) 134 134 { 135 135 snd_card_free(platform_get_drvdata(devptr)); 136 - return 0; 137 136 } 138 137 139 138 #ifdef CONFIG_PM_SLEEP ··· 160 161 161 162 static struct platform_driver snd_pmac_driver = { 162 163 .probe = snd_pmac_probe, 163 - .remove = snd_pmac_remove, 164 + .remove_new = snd_pmac_remove, 164 165 .driver = { 165 166 .name = SND_PMAC_DRIVER, 166 167 .pm = SND_PMAC_PM_OPS,