Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: adc: stm32-adc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-22-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
da8431b4 eedcd8c7

+2 -4
+2 -4
drivers/iio/adc/stm32-adc.c
··· 2513 2513 return ret; 2514 2514 } 2515 2515 2516 - static int stm32_adc_remove(struct platform_device *pdev) 2516 + static void stm32_adc_remove(struct platform_device *pdev) 2517 2517 { 2518 2518 struct iio_dev *indio_dev = platform_get_drvdata(pdev); 2519 2519 struct stm32_adc *adc = iio_priv(indio_dev); ··· 2532 2532 adc->rx_buf, adc->rx_dma_buf); 2533 2533 dma_release_channel(adc->dma_chan); 2534 2534 } 2535 - 2536 - return 0; 2537 2535 } 2538 2536 2539 2537 static int stm32_adc_suspend(struct device *dev) ··· 2657 2659 2658 2660 static struct platform_driver stm32_adc_driver = { 2659 2661 .probe = stm32_adc_probe, 2660 - .remove = stm32_adc_remove, 2662 + .remove_new = stm32_adc_remove, 2661 2663 .driver = { 2662 2664 .name = "stm32-adc", 2663 2665 .of_match_table = stm32_adc_of_match,