Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: adc: stm32-adc-core: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-21-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
eedcd8c7 e785bace

+2 -4
+2 -4
drivers/iio/adc/stm32-adc-core.c
··· 819 819 return ret; 820 820 } 821 821 822 - static int stm32_adc_remove(struct platform_device *pdev) 822 + static void stm32_adc_remove(struct platform_device *pdev) 823 823 { 824 824 struct stm32_adc_common *common = platform_get_drvdata(pdev); 825 825 struct stm32_adc_priv *priv = to_stm32_adc_priv(common); ··· 831 831 pm_runtime_disable(&pdev->dev); 832 832 pm_runtime_set_suspended(&pdev->dev); 833 833 pm_runtime_put_noidle(&pdev->dev); 834 - 835 - return 0; 836 834 } 837 835 838 836 static int stm32_adc_core_runtime_suspend(struct device *dev) ··· 911 913 912 914 static struct platform_driver stm32_adc_driver = { 913 915 .probe = stm32_adc_probe, 914 - .remove = stm32_adc_remove, 916 + .remove_new = stm32_adc_remove, 915 917 .driver = { 916 918 .name = "stm32-adc-core", 917 919 .of_match_table = stm32_adc_of_match,