Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: orientation: hid-sensor-rotation: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-43-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
d93837b8 44b25cf7

+2 -4
+2 -4
drivers/iio/orientation/hid-sensor-rotation.c
··· 327 327 } 328 328 329 329 /* Function to deinitialize the processing for usage id */ 330 - static int hid_dev_rot_remove(struct platform_device *pdev) 330 + static void hid_dev_rot_remove(struct platform_device *pdev) 331 331 { 332 332 struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data; 333 333 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 336 336 sensor_hub_remove_callback(hsdev, hsdev->usage); 337 337 iio_device_unregister(indio_dev); 338 338 hid_sensor_remove_trigger(indio_dev, &rot_state->common_attributes); 339 - 340 - return 0; 341 339 } 342 340 343 341 static const struct platform_device_id hid_dev_rot_ids[] = { ··· 362 364 .pm = &hid_sensor_pm_ops, 363 365 }, 364 366 .probe = hid_dev_rot_probe, 365 - .remove = hid_dev_rot_remove, 367 + .remove_new = hid_dev_rot_remove, 366 368 }; 367 369 module_platform_driver(hid_dev_rot_platform_driver); 368 370