Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: orientation: hid-sensor-incl-3d: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-42-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
44b25cf7 622adde5

+2 -4
+2 -4
drivers/iio/orientation/hid-sensor-incl-3d.c
··· 383 383 } 384 384 385 385 /* Function to deinitialize the processing for usage id */ 386 - static int hid_incl_3d_remove(struct platform_device *pdev) 386 + static void hid_incl_3d_remove(struct platform_device *pdev) 387 387 { 388 388 struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data; 389 389 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 392 392 sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_INCLINOMETER_3D); 393 393 iio_device_unregister(indio_dev); 394 394 hid_sensor_remove_trigger(indio_dev, &incl_state->common_attributes); 395 - 396 - return 0; 397 395 } 398 396 399 397 static const struct platform_device_id hid_incl_3d_ids[] = { ··· 410 412 .pm = &hid_sensor_pm_ops, 411 413 }, 412 414 .probe = hid_incl_3d_probe, 413 - .remove = hid_incl_3d_remove, 415 + .remove_new = hid_incl_3d_remove, 414 416 }; 415 417 module_platform_driver(hid_incl_3d_platform_driver); 416 418