Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: hda/tegra: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-10-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
d8a3441b 0505c87c

+2 -4
+2 -4
sound/pci/hda/hda_tegra.c
··· 580 580 return; /* no error return from async probe */ 581 581 } 582 582 583 - static int hda_tegra_remove(struct platform_device *pdev) 583 + static void hda_tegra_remove(struct platform_device *pdev) 584 584 { 585 585 snd_card_free(dev_get_drvdata(&pdev->dev)); 586 586 pm_runtime_disable(&pdev->dev); 587 - 588 - return 0; 589 587 } 590 588 591 589 static void hda_tegra_shutdown(struct platform_device *pdev) ··· 605 607 .of_match_table = hda_tegra_match, 606 608 }, 607 609 .probe = hda_tegra_probe, 608 - .remove = hda_tegra_remove, 610 + .remove_new = hda_tegra_remove, 609 611 .shutdown = hda_tegra_shutdown, 610 612 }; 611 613 module_platform_driver(tegra_platform_hda);