Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: mips/sgio2audio: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-9-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
0505c87c b54a2377

+2 -3
+2 -3
sound/mips/sgio2audio.c
··· 908 908 return 0; 909 909 } 910 910 911 - static int snd_sgio2audio_remove(struct platform_device *pdev) 911 + static void snd_sgio2audio_remove(struct platform_device *pdev) 912 912 { 913 913 struct snd_card *card = platform_get_drvdata(pdev); 914 914 915 915 snd_card_free(card); 916 - return 0; 917 916 } 918 917 919 918 static struct platform_driver sgio2audio_driver = { 920 919 .probe = snd_sgio2audio_probe, 921 - .remove = snd_sgio2audio_remove, 920 + .remove_new = snd_sgio2audio_remove, 922 921 .driver = { 923 922 .name = "sgio2audio", 924 923 }