Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

remoteproc: qcom_wcnss: Fix NULL vs IS_ERR() bug in wcnss_alloc_memory_region()

The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers. Update the checking to match.

Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/09a43da41ee277a80a3265348831e747f7b62620.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dan Carpenter and committed by
Bjorn Andersson
cda5dc12 cb200e41

+2 -2
+2 -2
drivers/remoteproc/qcom_wcnss.c
··· 538 538 wcnss->mem_phys = wcnss->mem_reloc = res.start; 539 539 wcnss->mem_size = resource_size(&res); 540 540 wcnss->mem_region = devm_ioremap_resource_wc(wcnss->dev, &res); 541 - if (!wcnss->mem_region) { 541 + if (IS_ERR(wcnss->mem_region)) { 542 542 dev_err(wcnss->dev, "unable to map memory region: %pR\n", &res); 543 - return -EBUSY; 543 + return PTR_ERR(wcnss->mem_region); 544 544 } 545 545 546 546 return 0;