Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region()

The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers. Update the checking to match.

Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dan Carpenter and committed by
Bjorn Andersson
cb200e41 e7839f77

+2 -2
+2 -2
drivers/remoteproc/qcom_q6v5_wcss.c
··· 887 887 wcss->mem_reloc = res.start; 888 888 wcss->mem_size = resource_size(&res); 889 889 wcss->mem_region = devm_ioremap_resource_wc(dev, &res); 890 - if (!wcss->mem_region) { 890 + if (IS_ERR(wcss->mem_region)) { 891 891 dev_err(dev, "unable to map memory region: %pR\n", &res); 892 - return -EBUSY; 892 + return PTR_ERR(wcss->mem_region); 893 893 } 894 894 895 895 return 0;