Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

remoteproc: qcom: pas: Fix a couple NULL vs IS_ERR() bugs

The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers. Update the checking to match.

Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/0599691acc394d9390da8fa0b5de3399b132b187.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dan Carpenter and committed by
Bjorn Andersson
e7839f77 5e6fee73

+4 -4
+4 -4
drivers/remoteproc/qcom_q6v5_pas.c
··· 559 559 pas->mem_phys = pas->mem_reloc = res.start; 560 560 pas->mem_size = resource_size(&res); 561 561 pas->mem_region = devm_ioremap_resource_wc(pas->dev, &res); 562 - if (!pas->mem_region) { 562 + if (IS_ERR(pas->mem_region)) { 563 563 dev_err(pas->dev, "unable to map memory region: %pR\n", &res); 564 - return -EBUSY; 564 + return PTR_ERR(pas->mem_region); 565 565 } 566 566 567 567 if (!pas->dtb_pas_id) ··· 576 576 pas->dtb_mem_phys = pas->dtb_mem_reloc = res.start; 577 577 pas->dtb_mem_size = resource_size(&res); 578 578 pas->dtb_mem_region = devm_ioremap_resource_wc(pas->dev, &res); 579 - if (!pas->dtb_mem_region) { 579 + if (IS_ERR(pas->dtb_mem_region)) { 580 580 dev_err(pas->dev, "unable to map dtb memory region: %pR\n", &res); 581 - return -EBUSY; 581 + return PTR_ERR(pas->dtb_mem_region); 582 582 } 583 583 584 584 return 0;