Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

interconnect: qcom/smd-rpm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20231031222851.3126434-19-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org>

authored by

Uwe Kleine-König and committed by
Georgi Djakov
c9ead908 237e1eda

+2 -4
+2 -4
drivers/interconnect/qcom/smd-rpm.c
··· 63 63 } 64 64 EXPORT_SYMBOL_GPL(qcom_icc_rpm_set_bus_rate); 65 65 66 - static int qcom_icc_rpm_smd_remove(struct platform_device *pdev) 66 + static void qcom_icc_rpm_smd_remove(struct platform_device *pdev) 67 67 { 68 68 icc_smd_rpm = NULL; 69 - 70 - return 0; 71 69 } 72 70 73 71 static int qcom_icc_rpm_smd_probe(struct platform_device *pdev) ··· 85 87 .name = "icc_smd_rpm", 86 88 }, 87 89 .probe = qcom_icc_rpm_smd_probe, 88 - .remove = qcom_icc_rpm_smd_remove, 90 + .remove_new = qcom_icc_rpm_smd_remove, 89 91 }; 90 92 module_platform_driver(qcom_interconnect_rpm_smd_driver); 91 93 MODULE_AUTHOR("Georgi Djakov <georgi.djakov@linaro.org>");