Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

interconnect: qcom/osm-l3: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20231031222851.3126434-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org>

authored by

Uwe Kleine-König and committed by
Georgi Djakov
237e1eda 9d960441

+2 -4
+2 -4
drivers/interconnect/qcom/osm-l3.c
··· 148 148 return 0; 149 149 } 150 150 151 - static int qcom_osm_l3_remove(struct platform_device *pdev) 151 + static void qcom_osm_l3_remove(struct platform_device *pdev) 152 152 { 153 153 struct qcom_osm_l3_icc_provider *qp = platform_get_drvdata(pdev); 154 154 155 155 icc_provider_deregister(&qp->provider); 156 156 icc_nodes_remove(&qp->provider); 157 - 158 - return 0; 159 157 } 160 158 161 159 static int qcom_osm_l3_probe(struct platform_device *pdev) ··· 290 292 291 293 static struct platform_driver osm_l3_driver = { 292 294 .probe = qcom_osm_l3_probe, 293 - .remove = qcom_osm_l3_remove, 295 + .remove_new = qcom_osm_l3_remove, 294 296 .driver = { 295 297 .name = "osm-l3", 296 298 .of_match_table = osm_l3_of_match,