Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC

Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only. This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Wolfram Sang <wsa@kernel.org>
Link: https://lore.kernel.org/r/20231108104343.24192-4-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

+14 -8
+14 -8
Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
··· 11 11 12 12 properties: 13 13 compatible: 14 - enum: 15 - - samsung,s3c2410-i2c 16 - - samsung,s3c2440-i2c 17 - # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs: 18 - - samsung,s3c2440-hdmiphy-i2c 19 - # For s3c2440-like I2C used as a host to SATA PHY controller on an 20 - # internal bus: 21 - - samsung,exynos5-sata-phy-i2c 14 + oneOf: 15 + - enum: 16 + - samsung,s3c2410-i2c 17 + - samsung,s3c2440-i2c 18 + # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs: 19 + - samsung,s3c2440-hdmiphy-i2c 20 + # For s3c2440-like I2C used as a host to SATA PHY controller on an 21 + # internal bus: 22 + - samsung,exynos5-sata-phy-i2c 23 + - items: 24 + - enum: 25 + - samsung,exynos7885-i2c 26 + - samsung,exynos850-i2c 27 + - const: samsung,s3c2440-i2c 22 28 23 29 '#address-cells': 24 30 const: 1