dt-bindings: i2c: exynos5: add specific compatibles for existing SoC

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only. This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.

Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Wolfram Sang <wsa@kernel.org>
Link: https://lore.kernel.org/r/20231108104343.24192-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Krzysztof Kozlowski 2 years ago 9da80ed6 4be756fd

+10 -2

2 changed files

expand all

Documentation

devicetree

bindings

i2c

i2c-exynos5.yaml

soc

samsung

exynos-usi.yaml

+9 -1

Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml

··· 25 25 - samsung,exynos5250-hsi2c # Exynos5250 and Exynos5420 26 26 - samsung,exynos5260-hsi2c # Exynos5260 27 27 - samsung,exynos7-hsi2c # Exynos7 28 - - samsung,exynosautov9-hsi2c # ExynosAutoV9 and Exynos850 28 + - samsung,exynosautov9-hsi2c 29 + - items: 30 + - enum: 31 + - samsung,exynos5433-hsi2c 32 + - const: samsung,exynos7-hsi2c 33 + - items: 34 + - enum: 35 + - samsung,exynos850-hsi2c 36 + - const: samsung,exynosautov9-hsi2c 29 37 - const: samsung,exynos5-hsi2c # Exynos5250 and Exynos5420 30 38 deprecated: true 31 39

+1 -1

Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml

··· 155 155 }; 156 156 157 157 hsi2c_0: i2c@13820000 { 158 - compatible = "samsung,exynosautov9-hsi2c"; 158 + compatible = "samsung,exynos850-hsi2c", "samsung,exynosautov9-hsi2c"; 159 159 reg = <0x13820000 0xc0>; 160 160 interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>; 161 161 #address-cells = <1>;