Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/geode/gxfb: Use fbdev I/O helpers

Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Cc: Andres Salomon <dilinger@queued.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-15-tzimmermann@suse.de

+2 -7
+1 -3
drivers/video/fbdev/geode/Kconfig
··· 29 29 config FB_GEODE_GX 30 30 tristate "AMD Geode GX framebuffer support" 31 31 depends on FB && FB_GEODE 32 - select FB_CFB_FILLRECT 33 - select FB_CFB_COPYAREA 34 - select FB_CFB_IMAGEBLIT 32 + select FB_IOMEM_HELPERS 35 33 select VIDEO_NOMODESET 36 34 help 37 35 Framebuffer driver for the display controller integrated into the
+1 -4
drivers/video/fbdev/geode/gxfb_core.c
··· 268 268 269 269 static const struct fb_ops gxfb_ops = { 270 270 .owner = THIS_MODULE, 271 + FB_DEFAULT_IOMEM_OPS, 271 272 .fb_check_var = gxfb_check_var, 272 273 .fb_set_par = gxfb_set_par, 273 274 .fb_setcolreg = gxfb_setcolreg, 274 275 .fb_blank = gxfb_blank, 275 - /* No HW acceleration for now. */ 276 - .fb_fillrect = cfb_fillrect, 277 - .fb_copyarea = cfb_copyarea, 278 - .fb_imageblit = cfb_imageblit, 279 276 }; 280 277 281 278 static struct fb_info *gxfb_init_fbinfo(struct device *dev)