Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/geode/gx1fb: Use fbdev I/O helpers

Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Cc: Andres Salomon <dilinger@queued.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-14-tzimmermann@suse.de

+2 -7
+1 -3
drivers/video/fbdev/geode/Kconfig
··· 45 45 config FB_GEODE_GX1 46 46 tristate "AMD Geode GX1 framebuffer support" 47 47 depends on FB && FB_GEODE 48 - select FB_CFB_FILLRECT 49 - select FB_CFB_COPYAREA 50 - select FB_CFB_IMAGEBLIT 48 + select FB_IOMEM_HELPERS 51 49 select VIDEO_NOMODESET 52 50 help 53 51 Framebuffer driver for the display controller integrated into the
+1 -4
drivers/video/fbdev/geode/gx1fb_core.c
··· 255 255 256 256 static const struct fb_ops gx1fb_ops = { 257 257 .owner = THIS_MODULE, 258 + FB_DEFAULT_IOMEM_OPS, 258 259 .fb_check_var = gx1fb_check_var, 259 260 .fb_set_par = gx1fb_set_par, 260 261 .fb_setcolreg = gx1fb_setcolreg, 261 262 .fb_blank = gx1fb_blank, 262 - /* No HW acceleration for now. */ 263 - .fb_fillrect = cfb_fillrect, 264 - .fb_copyarea = cfb_copyarea, 265 - .fb_imageblit = cfb_imageblit, 266 263 }; 267 264 268 265 static struct fb_info *gx1fb_init_fbinfo(struct device *dev)