Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hamradio: Delete unnecessary checks before the macro call “dev_kfree_skb”

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Markus Elfring and committed by
David S. Miller
b7deac31 038dab7e

+2 -4
+1 -2
drivers/net/hamradio/baycom_epp.c
··· 961 961 parport_write_control(pp, 0); /* reset the adapter */ 962 962 parport_release(bc->pdev); 963 963 parport_unregister_device(bc->pdev); 964 - if (bc->skb) 965 - dev_kfree_skb(bc->skb); 964 + dev_kfree_skb(bc->skb); 966 965 bc->skb = NULL; 967 966 printk(KERN_INFO "%s: close epp at iobase 0x%lx irq %u\n", 968 967 bc_drvname, dev->base_addr, dev->irq);
+1 -2
drivers/net/hamradio/hdlcdrv.c
··· 475 475 476 476 if (s->ops && s->ops->close) 477 477 i = s->ops->close(dev); 478 - if (s->skb) 479 - dev_kfree_skb(s->skb); 478 + dev_kfree_skb(s->skb); 480 479 s->skb = NULL; 481 480 s->opened = 0; 482 481 return i;