can: Delete unnecessary checks before the macro call “dev_kfree_skb”

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Sean Nyekjaer <sean@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Markus Elfring and committed by

David S. Miller 6 years ago 038dab7e 0f817a5e

+2 -4

2 changed files

expand all

drivers

net

can

spi

hi311x.c

mcp251x.c

+1 -2

drivers/net/can/spi/hi311x.c

··· 177 177 178 178 if (priv->tx_skb || priv->tx_len) 179 179 net->stats.tx_errors++; 180 - if (priv->tx_skb) 181 - dev_kfree_skb(priv->tx_skb); 180 + dev_kfree_skb(priv->tx_skb); 182 181 if (priv->tx_len) 183 182 can_free_echo_skb(priv->net, 0); 184 183 priv->tx_skb = NULL;

+1 -2

drivers/net/can/spi/mcp251x.c

··· 264 264 265 265 if (priv->tx_skb || priv->tx_len) 266 266 net->stats.tx_errors++; 267 - if (priv->tx_skb) 268 - dev_kfree_skb(priv->tx_skb); 267 + dev_kfree_skb(priv->tx_skb); 269 268 if (priv->tx_len) 270 269 can_free_echo_skb(priv->net, 0); 271 270 priv->tx_skb = NULL;