Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: mips/hal2: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-8-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
b54a2377 962bdc96

+2 -3
+2 -3
sound/mips/hal2.c
··· 877 877 return 0; 878 878 } 879 879 880 - static int hal2_remove(struct platform_device *pdev) 880 + static void hal2_remove(struct platform_device *pdev) 881 881 { 882 882 struct snd_card *card = platform_get_drvdata(pdev); 883 883 884 884 snd_card_free(card); 885 - return 0; 886 885 } 887 886 888 887 static struct platform_driver hal2_driver = { 889 888 .probe = hal2_probe, 890 - .remove = hal2_remove, 889 + .remove_new = hal2_remove, 891 890 .driver = { 892 891 .name = "sgihal2", 893 892 }