Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: portman2x4: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-7-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
962bdc96 5909d9e5

+2 -4
+2 -4
sound/drivers/portman2x4.c
··· 795 795 return err; 796 796 } 797 797 798 - static int snd_portman_remove(struct platform_device *pdev) 798 + static void snd_portman_remove(struct platform_device *pdev) 799 799 { 800 800 struct snd_card *card = platform_get_drvdata(pdev); 801 801 802 802 if (card) 803 803 snd_card_free(card); 804 - 805 - return 0; 806 804 } 807 805 808 806 809 807 static struct platform_driver snd_portman_driver = { 810 808 .probe = snd_portman_probe, 811 - .remove = snd_portman_remove, 809 + .remove_new = snd_portman_remove, 812 810 .driver = { 813 811 .name = PLATFORM_DRIVER, 814 812 }