Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge tag 'Wimplicit-fallthrough-5.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux

Pull Wimplicit-fallthrough updates from Gustavo A. R. Silva:
"Mark switch cases where we are expecting to fall through.

This is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Most of them have been baking in linux-next for a whole development
cycle. And with Stephen Rothwell's help, we've had linux-next
nag-emails going out for newly introduced code that triggers
-Wimplicit-fallthrough to avoid gaining more of these cases while we
work to remove the ones that are already present.

We are getting close to completing this work. Currently, there are
only 32 of 2311 of these cases left to be addressed in linux-next. I'm
auditing every case; I take a look into the code and analyze it in
order to determine if I'm dealing with an actual bug or a false
positive, as explained here:

https://lore.kernel.org/lkml/c2fad584-1705-a5f2-d63c-824e9b96cf50@embeddedor.com/

While working on this, I've found and fixed the several missing
break/return bugs, some of them introduced more than 5 years ago.

Once this work is finished, we'll be able to universally enable
"-Wimplicit-fallthrough" to avoid any of these kinds of bugs from
entering the kernel again"

* tag 'Wimplicit-fallthrough-5.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits)
memstick: mark expected switch fall-throughs
drm/nouveau/nvkm: mark expected switch fall-throughs
NFC: st21nfca: Fix fall-through warnings
NFC: pn533: mark expected switch fall-throughs
block: Mark expected switch fall-throughs
ASN.1: mark expected switch fall-through
lib/cmdline.c: mark expected switch fall-throughs
lib: zstd: Mark expected switch fall-throughs
scsi: sym53c8xx_2: sym_nvram: Mark expected switch fall-through
scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs
scsi: ppa: mark expected switch fall-through
scsi: osst: mark expected switch fall-throughs
scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs
scsi: lpfc: lpfc_nvme: Mark expected switch fall-through
scsi: lpfc: lpfc_nportdisc: Mark expected switch fall-through
scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs
scsi: lpfc: lpfc_els: Mark expected switch fall-throughs
scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs
scsi: imm: mark expected switch fall-throughs
scsi: csiostor: csio_wr: mark expected switch fall-through
...

+216 -68
+1 -1
drivers/block/drbd/drbd_int.h
··· 1778 1778 _drbd_set_state(_NS(device, disk, D_INCONSISTENT), CS_HARD, NULL); 1779 1779 break; 1780 1780 } 1781 - /* NOTE fall through for DRBD_META_IO_ERROR or DRBD_FORCE_DETACH */ 1781 + /* fall through - for DRBD_META_IO_ERROR or DRBD_FORCE_DETACH */ 1782 1782 case EP_DETACH: 1783 1783 case EP_CALL_HELPER: 1784 1784 /* Remember whether we saw a READ or WRITE error.
+2 -2
drivers/block/drbd/drbd_receiver.c
··· 3094 3094 rv = 1; 3095 3095 break; 3096 3096 } 3097 - /* Else fall through to one of the other strategies... */ 3097 + /* Else fall through - to one of the other strategies... */ 3098 3098 case ASB_DISCARD_OLDER_PRI: 3099 3099 if (self == 0 && peer == 1) { 3100 3100 rv = 1; ··· 3119 3119 } 3120 3120 if (after_sb_0p == ASB_DISCARD_ZERO_CHG) 3121 3121 break; 3122 - /* else: fall through */ 3122 + /* else, fall through */ 3123 3123 case ASB_DISCARD_LEAST_CHG: 3124 3124 if (ch_self < ch_peer) 3125 3125 rv = -1;
+1 -1
drivers/block/drbd/drbd_req.c
··· 866 866 } /* else: FIXME can this happen? */ 867 867 break; 868 868 } 869 - /* else, fall through to BARRIER_ACKED */ 869 + /* else, fall through - to BARRIER_ACKED */ 870 870 871 871 case BARRIER_ACKED: 872 872 /* barrier ack for READ requests does not make sense */
+1
drivers/block/rsxx/core.c
··· 439 439 * Fall through so the DMA devices can be attached and 440 440 * the user can attempt to pull off their data. 441 441 */ 442 + /* fall through */ 442 443 case CARD_STATE_GOOD: 443 444 st = rsxx_get_card_size8(card, &card->size8); 444 445 if (st)
+17
drivers/gpu/drm/nouveau/nvkm/engine/disp/hdmi.c
··· 23 23 */ 24 24 case 17: 25 25 subpack1_high = (raw_frame[16] << 16); 26 + /* fall through */ 26 27 case 16: 27 28 subpack1_high |= (raw_frame[15] << 8); 29 + /* fall through */ 28 30 case 15: 29 31 subpack1_high |= raw_frame[14]; 32 + /* fall through */ 30 33 case 14: 31 34 subpack1_low = (raw_frame[13] << 24); 35 + /* fall through */ 32 36 case 13: 33 37 subpack1_low |= (raw_frame[12] << 16); 38 + /* fall through */ 34 39 case 12: 35 40 subpack1_low |= (raw_frame[11] << 8); 41 + /* fall through */ 36 42 case 11: 37 43 subpack1_low |= raw_frame[10]; 44 + /* fall through */ 38 45 case 10: 39 46 subpack0_high = (raw_frame[9] << 16); 47 + /* fall through */ 40 48 case 9: 41 49 subpack0_high |= (raw_frame[8] << 8); 50 + /* fall through */ 42 51 case 8: 43 52 subpack0_high |= raw_frame[7]; 53 + /* fall through */ 44 54 case 7: 45 55 subpack0_low = (raw_frame[6] << 24); 56 + /* fall through */ 46 57 case 6: 47 58 subpack0_low |= (raw_frame[5] << 16); 59 + /* fall through */ 48 60 case 5: 49 61 subpack0_low |= (raw_frame[4] << 8); 62 + /* fall through */ 50 63 case 4: 51 64 subpack0_low |= raw_frame[3]; 65 + /* fall through */ 52 66 case 3: 53 67 header = (raw_frame[2] << 16); 68 + /* fall through */ 54 69 case 2: 55 70 header |= (raw_frame[1] << 8); 71 + /* fall through */ 56 72 case 1: 57 73 header |= raw_frame[0]; 74 + /* fall through */ 58 75 case 0: 59 76 break; 60 77 }
+1
drivers/gpu/drm/nouveau/nvkm/engine/dma/usernv04.c
··· 122 122 break; 123 123 case NV_MEM_ACCESS_WO: 124 124 dmaobj->flags0 |= 0x00008000; 125 + /* fall through */ 125 126 case NV_MEM_ACCESS_RW: 126 127 dmaobj->flags2 |= 0x00000002; 127 128 break;
+2
drivers/gpu/drm/nouveau/nvkm/engine/fifo/nv04.c
··· 117 117 switch (mthd) { 118 118 case 0x0000 ... 0x0000: /* subchannel's engine -> software */ 119 119 nvkm_wr32(device, 0x003280, (engine &= ~mask)); 120 + /* fall through */ 120 121 case 0x0180 ... 0x01fc: /* handle -> instance */ 121 122 data = nvkm_rd32(device, 0x003258) & 0x0000ffff; 123 + /* fall through */ 122 124 case 0x0100 ... 0x017c: 123 125 case 0x0200 ... 0x1ffc: /* pass method down to sw */ 124 126 if (!(engine & mask) && sw)
+1
drivers/gpu/drm/nouveau/nvkm/engine/fifo/nv40.c
··· 81 81 case 0x49: 82 82 case 0x4b: 83 83 nvkm_wr32(device, 0x002230, 0x00000001); 84 + /* fall through */ 84 85 case 0x40: 85 86 case 0x41: 86 87 case 0x42:
+1
drivers/gpu/drm/nouveau/nvkm/subdev/bios/perf.c
··· 135 135 break; 136 136 case 0x30: 137 137 info->script = nvbios_rd16(bios, perf + 0x02); 138 + /* fall through */ 138 139 case 0x35: 139 140 info->fanspeed = nvbios_rd08(bios, perf + 0x06); 140 141 info->voltage = nvbios_rd08(bios, perf + 0x07);
+1
drivers/gpu/drm/nouveau/nvkm/subdev/bios/pll.c
··· 134 134 device->chipset == 0xaa || 135 135 device->chipset == 0xac) 136 136 return g84_pll_mapping; 137 + /* fall through */ 137 138 default: 138 139 return NULL; 139 140 }
+1
drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c
··· 90 90 case NVKM_CLK_BOOST_NONE: 91 91 if (clk->base_khz && freq > clk->base_khz) 92 92 return false; 93 + /* fall through */ 93 94 case NVKM_CLK_BOOST_BIOS: 94 95 if (clk->boost_khz && freq > clk->boost_khz) 95 96 return false;
+1
drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c
··· 363 363 switch (clk->vsrc) { 364 364 case nv_clk_src_cclk: 365 365 mast |= 0x00400000; 366 + /* fall through */ 366 367 default: 367 368 nvkm_wr32(device, 0x4600, clk->vdiv); 368 369 }
+2
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv40.c
··· 131 131 nvkm_mask(device, 0x00402c, 0xc0771100, ram->ctrl); 132 132 nvkm_wr32(device, 0x004048, ram->coef); 133 133 nvkm_wr32(device, 0x004030, ram->coef); 134 + /* fall through */ 134 135 case 0x43: 135 136 case 0x49: 136 137 case 0x4b: 137 138 nvkm_mask(device, 0x004038, 0xc0771100, ram->ctrl); 138 139 nvkm_wr32(device, 0x00403c, ram->coef); 140 + /* fall through */ 139 141 default: 140 142 nvkm_mask(device, 0x004020, 0xc0771100, ram->ctrl); 141 143 nvkm_wr32(device, 0x004024, ram->coef);
+1
drivers/gpu/drm/nouveau/nvkm/subdev/mxm/nv50.c
··· 159 159 break; 160 160 case 0x0e: /* eDP, falls through to DPint */ 161 161 ctx.outp[1] |= 0x00010000; 162 + /* fall through */ 162 163 case 0x07: /* DP internal, wtf is this?? HP8670w */ 163 164 ctx.outp[1] |= 0x00000004; /* use_power_scripts? */ 164 165 type = DCB_CONNECTOR_eDP;
+2
drivers/memstick/host/jmb38x_ms.c
··· 259 259 case 3: 260 260 host->io_word[0] |= buf[off + 2] << 16; 261 261 host->io_pos++; 262 + /* fall through */ 262 263 case 2: 263 264 host->io_word[0] |= buf[off + 1] << 8; 264 265 host->io_pos++; 266 + /* fall through */ 265 267 case 1: 266 268 host->io_word[0] |= buf[off]; 267 269 host->io_pos++;
+2
drivers/memstick/host/tifm_ms.c
··· 166 166 case 3: 167 167 host->io_word |= buf[off + 2] << 16; 168 168 host->io_pos++; 169 + /* fall through */ 169 170 case 2: 170 171 host->io_word |= buf[off + 1] << 8; 171 172 host->io_pos++; 173 + /* fall through */ 172 174 case 1: 173 175 host->io_word |= buf[off]; 174 176 host->io_pos++;
+2
drivers/nfc/pn533/pn533.c
··· 2147 2147 2148 2148 break; 2149 2149 } 2150 + /* fall through */ 2150 2151 default: 2151 2152 /* jumbo frame ? */ 2152 2153 if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) { ··· 2274 2273 2275 2274 break; 2276 2275 } 2276 + /* fall through */ 2277 2277 default: 2278 2278 skb_put_u8(skb, 1); /*TG*/ 2279 2279
+2
drivers/nfc/st21nfca/dep.c
··· 400 400 default: 401 401 return 1; 402 402 } 403 + break; 403 404 default: 404 405 return 1; 405 406 } ··· 620 619 switch (ST21NFCA_NFC_DEP_PFB_TYPE(dep_res->pfb)) { 621 620 case ST21NFCA_NFC_DEP_PFB_ACK_NACK_PDU: 622 621 pr_err("Received a ACK/NACK PDU\n"); 622 + /* fall through */ 623 623 case ST21NFCA_NFC_DEP_PFB_I_PDU: 624 624 info->dep_info.curr_nfc_dep_pni = 625 625 ST21NFCA_NFC_DEP_PFB_PNI(dep_res->pfb + 1);
+9 -3
drivers/scsi/aic7xxx/aic7xxx_core.c
··· 4920 4920 } 4921 4921 ahc_dma_tag_destroy(ahc, scb_data->sg_dmat); 4922 4922 } 4923 + /* fall through */ 4923 4924 case 6: 4924 4925 ahc_dmamap_unload(ahc, scb_data->sense_dmat, 4925 4926 scb_data->sense_dmamap); 4927 + /* fall through */ 4926 4928 case 5: 4927 4929 ahc_dmamem_free(ahc, scb_data->sense_dmat, scb_data->sense, 4928 4930 scb_data->sense_dmamap); 4929 4931 ahc_dmamap_destroy(ahc, scb_data->sense_dmat, 4930 4932 scb_data->sense_dmamap); 4933 + /* fall through */ 4931 4934 case 4: 4932 4935 ahc_dma_tag_destroy(ahc, scb_data->sense_dmat); 4936 + /* fall through */ 4933 4937 case 3: 4934 4938 ahc_dmamap_unload(ahc, scb_data->hscb_dmat, 4935 4939 scb_data->hscb_dmamap); 4940 + /* fall through */ 4936 4941 case 2: 4937 4942 ahc_dmamem_free(ahc, scb_data->hscb_dmat, scb_data->hscbs, 4938 4943 scb_data->hscb_dmamap); 4939 4944 ahc_dmamap_destroy(ahc, scb_data->hscb_dmat, 4940 4945 scb_data->hscb_dmamap); 4946 + /* fall through */ 4941 4947 case 1: 4942 4948 ahc_dma_tag_destroy(ahc, scb_data->hscb_dmat); 4943 4949 break; ··· 6008 6002 if ((scb->flags & SCB_ACTIVE) == 0) 6009 6003 printk("Inactive SCB in Waiting List\n"); 6010 6004 ahc_done(ahc, scb); 6011 - /* FALLTHROUGH */ 6012 6005 } 6006 + /* fall through */ 6013 6007 case SEARCH_REMOVE: 6014 6008 next = ahc_rem_wscb(ahc, next, prev); 6015 6009 break; ··· 7014 7008 } 7015 7009 address -= address_offset; 7016 7010 fmt3_ins->address = address; 7017 - /* FALLTHROUGH */ 7018 7011 } 7012 + /* fall through */ 7019 7013 case AIC_OP_OR: 7020 7014 case AIC_OP_AND: 7021 7015 case AIC_OP_XOR: ··· 7041 7035 fmt1_ins->opcode = AIC_OP_AND; 7042 7036 fmt1_ins->immediate = 0xff; 7043 7037 } 7044 - /* FALLTHROUGH */ 7038 + /* fall through */ 7045 7039 case AIC_OP_ROL: 7046 7040 if ((ahc->features & AHC_ULTRA2) != 0) { 7047 7041 int i, count;
+1
drivers/scsi/be2iscsi/be_iscsi.c
··· 679 679 case ISCSI_PARAM_MAX_XMIT_DLENGTH: 680 680 if (conn->max_xmit_dlength > 65536) 681 681 conn->max_xmit_dlength = 65536; 682 + /* fall through */ 682 683 default: 683 684 return 0; 684 685 }
+1
drivers/scsi/be2iscsi/be_main.c
··· 1532 1532 break; 1533 1533 case UNSOL_DATA_DIGEST_ERROR_NOTIFY: 1534 1534 error = 1; 1535 + /* fall through */ 1535 1536 case UNSOL_DATA_NOTIFY: 1536 1537 pasync_handle = pasync_ctx->async_entry[ci].data; 1537 1538 break;
+3 -3
drivers/scsi/bfa/bfa_fcpim.c
··· 2586 2586 case FCP_IODIR_RW: 2587 2587 bfa_stats(itnim, input_reqs); 2588 2588 bfa_stats(itnim, output_reqs); 2589 + /* fall through */ 2589 2590 default: 2590 2591 bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa)); 2591 2592 } ··· 2821 2820 2822 2821 case BFI_IOIM_STS_TIMEDOUT: 2823 2822 bfa_stats(ioim->itnim, iocomp_timedout); 2823 + /* fall through */ 2824 2824 case BFI_IOIM_STS_ABORTED: 2825 2825 rsp->io_status = BFI_IOIM_STS_ABORTED; 2826 2826 bfa_stats(ioim->itnim, iocomp_aborted); ··· 3217 3215 switch (event) { 3218 3216 case BFA_TSKIM_SM_DONE: 3219 3217 bfa_reqq_wcancel(&tskim->reqq_wait); 3220 - /* 3221 - * Fall through !!! 3222 - */ 3218 + /* fall through */ 3223 3219 case BFA_TSKIM_SM_QRESUME: 3224 3220 bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup); 3225 3221 bfa_tskim_send_abort(tskim);
+1
drivers/scsi/csiostor/csio_wr.c
··· 808 808 809 809 csio_q_eqid(hw, i) = CSIO_MAX_QID; 810 810 } 811 + /* fall through */ 811 812 case CSIO_INGRESS: 812 813 if (csio_q_iqid(hw, i) != CSIO_MAX_QID) { 813 814 csio_wr_cleanup_iq_ftr(hw, i);
+17 -16
drivers/scsi/imm.c
··· 796 796 return 0; 797 797 } 798 798 return 1; /* wait until imm_wakeup claims parport */ 799 - /* Phase 1 - Connected */ 800 - case 1: 799 + 800 + case 1: /* Phase 1 - Connected */ 801 801 imm_connect(dev, CONNECT_EPP_MAYBE); 802 802 cmd->SCp.phase++; 803 + /* fall through */ 803 804 804 - /* Phase 2 - We are now talking to the scsi bus */ 805 - case 2: 805 + case 2: /* Phase 2 - We are now talking to the scsi bus */ 806 806 if (!imm_select(dev, scmd_id(cmd))) { 807 807 imm_fail(dev, DID_NO_CONNECT); 808 808 return 0; 809 809 } 810 810 cmd->SCp.phase++; 811 + /* fall through */ 811 812 812 - /* Phase 3 - Ready to accept a command */ 813 - case 3: 813 + case 3: /* Phase 3 - Ready to accept a command */ 814 814 w_ctr(ppb, 0x0c); 815 815 if (!(r_str(ppb) & 0x80)) 816 816 return 1; ··· 818 818 if (!imm_send_command(cmd)) 819 819 return 0; 820 820 cmd->SCp.phase++; 821 + /* fall through */ 821 822 822 - /* Phase 4 - Setup scatter/gather buffers */ 823 - case 4: 823 + case 4: /* Phase 4 - Setup scatter/gather buffers */ 824 824 if (scsi_bufflen(cmd)) { 825 825 cmd->SCp.buffer = scsi_sglist(cmd); 826 826 cmd->SCp.this_residual = cmd->SCp.buffer->length; ··· 834 834 cmd->SCp.phase++; 835 835 if (cmd->SCp.this_residual & 0x01) 836 836 cmd->SCp.this_residual++; 837 - /* Phase 5 - Pre-Data transfer stage */ 838 - case 5: 837 + /* fall through */ 838 + 839 + case 5: /* Phase 5 - Pre-Data transfer stage */ 839 840 /* Spin lock for BUSY */ 840 841 w_ctr(ppb, 0x0c); 841 842 if (!(r_str(ppb) & 0x80)) ··· 851 850 if (imm_negotiate(dev)) 852 851 return 0; 853 852 cmd->SCp.phase++; 853 + /* fall through */ 854 854 855 - /* Phase 6 - Data transfer stage */ 856 - case 6: 855 + case 6: /* Phase 6 - Data transfer stage */ 857 856 /* Spin lock for BUSY */ 858 857 w_ctr(ppb, 0x0c); 859 858 if (!(r_str(ppb) & 0x80)) ··· 867 866 return 1; 868 867 } 869 868 cmd->SCp.phase++; 869 + /* fall through */ 870 870 871 - /* Phase 7 - Post data transfer stage */ 872 - case 7: 871 + case 7: /* Phase 7 - Post data transfer stage */ 873 872 if ((dev->dp) && (dev->rd)) { 874 873 if ((dev->mode == IMM_NIBBLE) || (dev->mode == IMM_PS2)) { 875 874 w_ctr(ppb, 0x4); ··· 879 878 } 880 879 } 881 880 cmd->SCp.phase++; 881 + /* fall through */ 882 882 883 - /* Phase 8 - Read status/message */ 884 - case 8: 883 + case 8: /* Phase 8 - Read status/message */ 885 884 /* Check for data overrun */ 886 885 if (imm_wait(dev) != (unsigned char) 0xb8) { 887 886 imm_fail(dev, DID_ERROR);
+2
drivers/scsi/lpfc/lpfc_ct.c
··· 3092 3092 case SLI_MGMT_GHAT: 3093 3093 case SLI_MGMT_GRPL: 3094 3094 rsp_size = FC_MAX_NS_RSP; 3095 + /* fall through */ 3095 3096 case SLI_MGMT_DHBA: 3096 3097 case SLI_MGMT_DHAT: 3097 3098 pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID; ··· 3105 3104 case SLI_MGMT_GPAT: 3106 3105 case SLI_MGMT_GPAS: 3107 3106 rsp_size = FC_MAX_NS_RSP; 3107 + /* fall through */ 3108 3108 case SLI_MGMT_DPRT: 3109 3109 case SLI_MGMT_DPA: 3110 3110 pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
+1
drivers/scsi/lpfc/lpfc_els.c
··· 8775 8775 lpfc_nlp_put(ndlp); 8776 8776 return; 8777 8777 } 8778 + /* fall through */ 8778 8779 8779 8780 default: 8780 8781 /* Try to recover from this error */
+3 -1
drivers/scsi/lpfc/lpfc_hbadisc.c
··· 4667 4667 case CMD_GEN_REQUEST64_CR: 4668 4668 if (iocb->context_un.ndlp == ndlp) 4669 4669 return 1; 4670 + /* fall through */ 4670 4671 case CMD_ELS_REQUEST64_CR: 4671 4672 if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID) 4672 4673 return 1; 4674 + /* fall through */ 4673 4675 case CMD_XMIT_ELS_RSP64_CX: 4674 4676 if (iocb->context1 == (uint8_t *) ndlp) 4675 4677 return 1; ··· 5858 5856 5859 5857 case LPFC_LINK_UP: 5860 5858 lpfc_issue_clear_la(phba, vport); 5861 - /* Drop thru */ 5859 + /* fall through */ 5862 5860 case LPFC_LINK_UNKNOWN: 5863 5861 case LPFC_WARM_START: 5864 5862 case LPFC_INIT_START:
+1
drivers/scsi/lpfc/lpfc_nportdisc.c
··· 360 360 case NLP_STE_NPR_NODE: 361 361 if (!(ndlp->nlp_flag & NLP_NPR_ADISC)) 362 362 break; 363 + /* fall through */ 363 364 case NLP_STE_REG_LOGIN_ISSUE: 364 365 case NLP_STE_PRLI_ISSUE: 365 366 case NLP_STE_UNMAPPED_NODE:
+1
drivers/scsi/lpfc/lpfc_nvme.c
··· 1106 1106 lpfc_ncmd, nCmd, 1107 1107 lpfc_ncmd->cur_iocbq.sli4_xritag, 1108 1108 bf_get(lpfc_wcqe_c_xb, wcqe)); 1109 + /* fall through */ 1109 1110 default: 1110 1111 out_err: 1111 1112 lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_IOERR,
+4 -4
drivers/scsi/lpfc/lpfc_scsi.c
··· 1137 1137 1138 1138 break; 1139 1139 } 1140 - /* Drop thru */ 1140 + /* fall through */ 1141 1141 case SCSI_PROT_WRITE_INSERT: 1142 1142 /* 1143 1143 * For WRITE_INSERT, force the error ··· 1256 1256 rc = BG_ERR_TGT | BG_ERR_CHECK; 1257 1257 break; 1258 1258 } 1259 - /* Drop thru */ 1259 + /* fall through */ 1260 1260 case SCSI_PROT_WRITE_INSERT: 1261 1261 /* 1262 1262 * For WRITE_INSERT, force the ··· 1338 1338 switch (op) { 1339 1339 case SCSI_PROT_WRITE_PASS: 1340 1340 rc = BG_ERR_CHECK; 1341 - /* Drop thru */ 1341 + /* fall through */ 1342 1342 1343 1343 case SCSI_PROT_WRITE_INSERT: 1344 1344 /* ··· 3822 3822 lpfc_cmd->cur_iocbq.sli4_lxritag, 3823 3823 0, 0); 3824 3824 } 3825 - /* else: fall through */ 3825 + /* fall through */ 3826 3826 default: 3827 3827 cmd->result = DID_ERROR << 16; 3828 3828 break;
+6
drivers/scsi/osst.c
··· 216 216 switch (sense[0] & 0x7f) { 217 217 case 0x71: 218 218 s->deferred = 1; 219 + /* fall through */ 219 220 case 0x70: 220 221 s->fixed_format = 1; 221 222 s->flags = sense[2] & 0xe0; 222 223 break; 223 224 case 0x73: 224 225 s->deferred = 1; 226 + /* fall through */ 225 227 case 0x72: 226 228 s->fixed_format = 0; 227 229 ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4); ··· 593 591 dat->dat_list[0].flags = frame_type==OS_FRAME_TYPE_MARKER? 594 592 OS_DAT_FLAGS_MARK:OS_DAT_FLAGS_DATA; 595 593 dat->dat_list[0].reserved = 0; 594 + /* fall through */ 596 595 case OS_FRAME_TYPE_EOD: 597 596 aux->update_frame_cntr = htonl(0); 598 597 par->partition_num = OS_DATA_PARTITION; ··· 4089 4086 switch (cmd_in) { 4090 4087 case MTFSFM: 4091 4088 chg_eof = 0; /* Changed from the FSF after this */ 4089 + /* fall through */ 4092 4090 case MTFSF: 4093 4091 if (STp->raw) 4094 4092 return (-EIO); ··· 4105 4101 4106 4102 case MTBSF: 4107 4103 chg_eof = 0; /* Changed from the FSF after this */ 4104 + /* fall through */ 4108 4105 case MTBSFM: 4109 4106 if (STp->raw) 4110 4107 return (-EIO); ··· 4317 4312 name, STp->block_size); 4318 4313 return 0; 4319 4314 } 4315 + /* fall through */ 4320 4316 case MTSETDENSITY: /* Set tape density */ 4321 4317 case MTSETDRVBUFFER: /* Set drive buffering */ 4322 4318 case SET_DENS_AND_BLK: /* Set density and block size */
+1
drivers/scsi/ppa.c
··· 717 717 } 718 718 cmd->SCp.phase++; 719 719 } 720 + /* fall through */ 720 721 721 722 case 2: /* Phase 2 - We are now talking to the scsi bus */ 722 723 if (!ppa_select(dev, scmd_id(cmd))) {
+2
drivers/scsi/sym53c8xx_2/sym_hipd.c
··· 3072 3072 sym_print_addr(cp->cmd, "%s\n", 3073 3073 s_status == S_BUSY ? "BUSY" : "QUEUE FULL\n"); 3074 3074 } 3075 + /* fall through */ 3075 3076 default: /* S_INT, S_INT_COND_MET, S_CONFLICT */ 3076 3077 sym_complete_error (np, cp); 3077 3078 break; ··· 4633 4632 * Negotiation failed. 4634 4633 * Target does not want answer message. 4635 4634 */ 4635 + /* fall through */ 4636 4636 case SIR_NEGO_PROTO: 4637 4637 sym_nego_default(np, tp, cp); 4638 4638 goto out;
+1
drivers/scsi/sym53c8xx_2/sym_nvram.c
··· 708 708 data, len); 709 709 if (!x) 710 710 break; 711 + /* fall through */ 711 712 default: 712 713 x = sym_read_T93C46_nvram(np, nvram); 713 714 break;
+6
fs/adfs/dir_f.c
··· 24 24 25 25 switch (len) { 26 26 case 4: val |= p[3] << 24; 27 + /* fall through */ 27 28 case 3: val |= p[2] << 16; 29 + /* fall through */ 28 30 case 2: val |= p[1] << 8; 31 + /* fall through */ 29 32 default: val |= p[0]; 30 33 } 31 34 return val; ··· 38 35 { 39 36 switch (len) { 40 37 case 4: p[3] = val >> 24; 38 + /* fall through */ 41 39 case 3: p[2] = val >> 16; 40 + /* fall through */ 42 41 case 2: p[1] = val >> 8; 42 + /* fall through */ 43 43 default: p[0] = val; 44 44 } 45 45 }
+2 -1
fs/affs/super.c
··· 481 481 break; 482 482 case MUFS_OFS: 483 483 affs_set_opt(sbi->s_flags, SF_MUFS); 484 - /* fall thru */ 484 + /* fall through */ 485 485 case FS_OFS: 486 486 affs_set_opt(sbi->s_flags, SF_OFS); 487 487 sb->s_flags |= SB_NOEXEC; ··· 489 489 case MUFS_DCOFS: 490 490 case MUFS_INTLOFS: 491 491 affs_set_opt(sbi->s_flags, SF_MUFS); 492 + /* fall through */ 492 493 case FS_DCOFS: 493 494 case FS_INTLOFS: 494 495 affs_set_opt(sbi->s_flags, SF_INTL);
+8
fs/afs/cmservice.c
··· 285 285 call->unmarshall++; 286 286 287 287 /* extract the FID array and its count in two steps */ 288 + /* fall through */ 288 289 case 1: 289 290 _debug("extract FID count"); 290 291 ret = afs_extract_data(call, true); ··· 305 304 afs_extract_to_buf(call, call->count * 3 * 4); 306 305 call->unmarshall++; 307 306 307 + /* Fall through */ 308 308 case 2: 309 309 _debug("extract FID array"); 310 310 ret = afs_extract_data(call, true); ··· 331 329 call->unmarshall++; 332 330 333 331 /* extract the callback array and its count in two steps */ 332 + /* fall through */ 334 333 case 3: 335 334 _debug("extract CB count"); 336 335 ret = afs_extract_data(call, true); ··· 347 344 iov_iter_discard(&call->iter, READ, call->count2 * 3 * 4); 348 345 call->unmarshall++; 349 346 347 + /* Fall through */ 350 348 case 4: 351 349 _debug("extract discard %zu/%u", 352 350 iov_iter_count(&call->iter), call->count2 * 3 * 4); ··· 426 422 afs_extract_to_buf(call, 11 * sizeof(__be32)); 427 423 call->unmarshall++; 428 424 425 + /* Fall through */ 429 426 case 1: 430 427 _debug("extract UUID"); 431 428 ret = afs_extract_data(call, false); ··· 542 537 afs_extract_to_buf(call, 11 * sizeof(__be32)); 543 538 call->unmarshall++; 544 539 540 + /* Fall through */ 545 541 case 1: 546 542 _debug("extract UUID"); 547 543 ret = afs_extract_data(call, false); ··· 679 673 call->unmarshall++; 680 674 681 675 /* extract the FID array and its count in two steps */ 676 + /* Fall through */ 682 677 case 1: 683 678 _debug("extract FID count"); 684 679 ret = afs_extract_data(call, true); ··· 699 692 afs_extract_to_buf(call, size); 700 693 call->unmarshall++; 701 694 695 + /* Fall through */ 702 696 case 2: 703 697 _debug("extract FID array"); 704 698 ret = afs_extract_data(call, false);
+2
fs/afs/file.c
··· 300 300 /* page will not be cached */ 301 301 case -ENOBUFS: 302 302 _debug("cache said ENOBUFS"); 303 + 304 + /* fall through */ 303 305 default: 304 306 go_on: 305 307 req = kzalloc(sizeof(struct afs_read) + sizeof(struct page *),
+1
fs/afs/flock.c
··· 303 303 return; 304 304 } 305 305 306 + /* Fall through */ 306 307 default: 307 308 /* Looks like a lock request was withdrawn. */ 308 309 spin_unlock(&vnode->lock);
+19 -12
fs/afs/fsclient.c
··· 498 498 afs_extract_to_tmp(call); 499 499 } 500 500 501 - /* extract the returned data length */ 501 + /* Fall through - and extract the returned data length */ 502 502 case 1: 503 503 _debug("extract data length"); 504 504 ret = afs_extract_data(call, true); ··· 525 525 iov_iter_bvec(&call->iter, READ, call->bvec, 1, size); 526 526 ASSERTCMP(size, <=, PAGE_SIZE); 527 527 528 - /* extract the returned data */ 528 + /* Fall through - and extract the returned data */ 529 529 case 2: 530 530 _debug("extract data %zu/%llu", 531 531 iov_iter_count(&call->iter), req->remain); ··· 552 552 /* Discard any excess data the server gave us */ 553 553 iov_iter_discard(&call->iter, READ, req->actual_len - req->len); 554 554 call->unmarshall = 3; 555 + 556 + /* Fall through */ 555 557 case 3: 556 558 _debug("extract discard %zu/%llu", 557 559 iov_iter_count(&call->iter), req->actual_len - req->len); ··· 566 564 call->unmarshall = 4; 567 565 afs_extract_to_buf(call, (21 + 3 + 6) * 4); 568 566 569 - /* extract the metadata */ 567 + /* Fall through - and extract the metadata */ 570 568 case 4: 571 569 ret = afs_extract_data(call, false); 572 570 if (ret < 0) ··· 1636 1634 call->unmarshall++; 1637 1635 afs_extract_to_buf(call, 12 * 4); 1638 1636 1639 - /* extract the returned status record */ 1637 + /* Fall through - and extract the returned status record */ 1640 1638 case 1: 1641 1639 _debug("extract status"); 1642 1640 ret = afs_extract_data(call, true); ··· 1648 1646 call->unmarshall++; 1649 1647 afs_extract_to_tmp(call); 1650 1648 1651 - /* extract the volume name length */ 1649 + /* Fall through - and extract the volume name length */ 1652 1650 case 2: 1653 1651 ret = afs_extract_data(call, true); 1654 1652 if (ret < 0) ··· 1663 1661 afs_extract_begin(call, call->reply[2], size); 1664 1662 call->unmarshall++; 1665 1663 1666 - /* extract the volume name */ 1664 + /* Fall through - and extract the volume name */ 1667 1665 case 3: 1668 1666 _debug("extract volname"); 1669 1667 ret = afs_extract_data(call, true); ··· 1676 1674 afs_extract_to_tmp(call); 1677 1675 call->unmarshall++; 1678 1676 1679 - /* extract the offline message length */ 1677 + /* Fall through - and extract the offline message length */ 1680 1678 case 4: 1681 1679 ret = afs_extract_data(call, true); 1682 1680 if (ret < 0) ··· 1691 1689 afs_extract_begin(call, call->reply[2], size); 1692 1690 call->unmarshall++; 1693 1691 1694 - /* extract the offline message */ 1692 + /* Fall through - and extract the offline message */ 1695 1693 case 5: 1696 1694 _debug("extract offline"); 1697 1695 ret = afs_extract_data(call, true); ··· 1705 1703 afs_extract_to_tmp(call); 1706 1704 call->unmarshall++; 1707 1705 1708 - /* extract the message of the day length */ 1706 + /* Fall through - and extract the message of the day length */ 1709 1707 case 6: 1710 1708 ret = afs_extract_data(call, true); 1711 1709 if (ret < 0) ··· 1720 1718 afs_extract_begin(call, call->reply[2], size); 1721 1719 call->unmarshall++; 1722 1720 1723 - /* extract the message of the day */ 1721 + /* Fall through - and extract the message of the day */ 1724 1722 case 7: 1725 1723 _debug("extract motd"); 1726 1724 ret = afs_extract_data(call, false); ··· 2018 2016 afs_extract_to_tmp(call); 2019 2017 call->unmarshall++; 2020 2018 2021 - /* Extract the capabilities word count */ 2019 + /* Fall through - and extract the capabilities word count */ 2022 2020 case 1: 2023 2021 ret = afs_extract_data(call, true); 2024 2022 if (ret < 0) ··· 2031 2029 iov_iter_discard(&call->iter, READ, count * sizeof(__be32)); 2032 2030 call->unmarshall++; 2033 2031 2034 - /* Extract capabilities words */ 2032 + /* Fall through - and extract capabilities words */ 2035 2033 case 2: 2036 2034 ret = afs_extract_data(call, false); 2037 2035 if (ret < 0) ··· 2208 2206 call->unmarshall++; 2209 2207 2210 2208 /* Extract the file status count and array in two steps */ 2209 + /* Fall through */ 2211 2210 case 1: 2212 2211 _debug("extract status count"); 2213 2212 ret = afs_extract_data(call, true); ··· 2226 2223 more_counts: 2227 2224 afs_extract_to_buf(call, 21 * sizeof(__be32)); 2228 2225 2226 + /* Fall through */ 2229 2227 case 2: 2230 2228 _debug("extract status array %u", call->count); 2231 2229 ret = afs_extract_data(call, true); ··· 2250 2246 afs_extract_to_tmp(call); 2251 2247 2252 2248 /* Extract the callback count and array in two steps */ 2249 + /* Fall through */ 2253 2250 case 3: 2254 2251 _debug("extract CB count"); 2255 2252 ret = afs_extract_data(call, true); ··· 2267 2262 more_cbs: 2268 2263 afs_extract_to_buf(call, 3 * sizeof(__be32)); 2269 2264 2265 + /* Fall through */ 2270 2266 case 4: 2271 2267 _debug("extract CB array"); 2272 2268 ret = afs_extract_data(call, true); ··· 2290 2284 afs_extract_to_buf(call, 6 * sizeof(__be32)); 2291 2285 call->unmarshall++; 2292 2286 2287 + /* Fall through */ 2293 2288 case 5: 2294 2289 ret = afs_extract_data(call, false); 2295 2290 if (ret < 0)
+9
fs/afs/misc.c
··· 131 131 if (e->error == -ETIMEDOUT || 132 132 e->error == -ETIME) 133 133 return; 134 + /* Fall through */ 134 135 case -ETIMEDOUT: 135 136 case -ETIME: 136 137 if (e->error == -ENOMEM || 137 138 e->error == -ENONET) 138 139 return; 140 + /* Fall through */ 139 141 case -ENOMEM: 140 142 case -ENONET: 141 143 if (e->error == -ERFKILL) 142 144 return; 145 + /* Fall through */ 143 146 case -ERFKILL: 144 147 if (e->error == -EADDRNOTAVAIL) 145 148 return; 149 + /* Fall through */ 146 150 case -EADDRNOTAVAIL: 147 151 if (e->error == -ENETUNREACH) 148 152 return; 153 + /* Fall through */ 149 154 case -ENETUNREACH: 150 155 if (e->error == -EHOSTUNREACH) 151 156 return; 157 + /* Fall through */ 152 158 case -EHOSTUNREACH: 153 159 if (e->error == -EHOSTDOWN) 154 160 return; 161 + /* Fall through */ 155 162 case -EHOSTDOWN: 156 163 if (e->error == -ECONNREFUSED) 157 164 return; 165 + /* Fall through */ 158 166 case -ECONNREFUSED: 159 167 if (e->error == -ECONNRESET) 160 168 return; 169 + /* Fall through */ 161 170 case -ECONNRESET: /* Responded, but call expired. */ 162 171 if (e->responded) 163 172 return;
+1
fs/afs/rxrpc.c
··· 923 923 _debug("oom"); 924 924 rxrpc_kernel_abort_call(net->socket, call->rxcall, 925 925 RX_USER_ABORT, -ENOMEM, "KOO"); 926 + /* Fall through */ 926 927 default: 927 928 _leave(" [error]"); 928 929 return;
+11 -7
fs/afs/vlclient.c
··· 195 195 sizeof(struct afs_uuid__xdr) + 3 * sizeof(__be32)); 196 196 call->unmarshall++; 197 197 198 - /* Extract the returned uuid, uniquifier, nentries and blkaddrs size */ 198 + /* Extract the returned uuid, uniquifier, nentries and 199 + * blkaddrs size */ 200 + /* Fall through */ 199 201 case 1: 200 202 ret = afs_extract_data(call, true); 201 203 if (ret < 0) ··· 222 220 count = min(call->count, 4U); 223 221 afs_extract_to_buf(call, count * sizeof(__be32)); 224 222 225 - /* Extract entries */ 223 + /* Fall through - and extract entries */ 226 224 case 2: 227 225 ret = afs_extract_data(call, call->count > 4); 228 226 if (ret < 0) ··· 325 323 afs_extract_to_tmp(call); 326 324 call->unmarshall++; 327 325 328 - /* Extract the capabilities word count */ 326 + /* Fall through - and extract the capabilities word count */ 329 327 case 1: 330 328 ret = afs_extract_data(call, true); 331 329 if (ret < 0) ··· 338 336 call->unmarshall++; 339 337 afs_extract_discard(call, count * sizeof(__be32)); 340 338 341 - /* Extract capabilities words */ 339 + /* Fall through - and extract capabilities words */ 342 340 case 2: 343 341 ret = afs_extract_data(call, false); 344 342 if (ret < 0) ··· 438 436 /* Extract the returned uuid, uniquifier, fsEndpoints count and 439 437 * either the first fsEndpoint type or the volEndpoints 440 438 * count if there are no fsEndpoints. */ 439 + /* Fall through */ 441 440 case 1: 442 441 ret = afs_extract_data(call, true); 443 442 if (ret < 0) ··· 479 476 afs_extract_to_buf(call, size); 480 477 call->unmarshall = 2; 481 478 482 - /* Extract fsEndpoints[] entries */ 479 + /* Fall through - and extract fsEndpoints[] entries */ 483 480 case 2: 484 481 ret = afs_extract_data(call, true); 485 482 if (ret < 0) ··· 532 529 * extract the type of the next endpoint when we extract the 533 530 * data of the current one, but this is the first... 534 531 */ 532 + /* Fall through */ 535 533 case 3: 536 534 ret = afs_extract_data(call, true); 537 535 if (ret < 0) ··· 559 555 afs_extract_to_buf(call, size); 560 556 call->unmarshall = 4; 561 557 562 - /* Extract volEndpoints[] entries */ 558 + /* Fall through - and extract volEndpoints[] entries */ 563 559 case 4: 564 560 ret = afs_extract_data(call, true); 565 561 if (ret < 0) ··· 595 591 afs_extract_discard(call, 0); 596 592 call->unmarshall = 5; 597 593 598 - /* Done */ 594 + /* Fall through - Done */ 599 595 case 5: 600 596 ret = afs_extract_data(call, false); 601 597 if (ret < 0)
+20 -10
fs/afs/yfsclient.c
··· 544 544 afs_extract_to_tmp64(call); 545 545 call->unmarshall++; 546 546 547 - /* extract the returned data length */ 547 + /* Fall through - and extract the returned data length */ 548 548 case 1: 549 549 _debug("extract data length"); 550 550 ret = afs_extract_data(call, true); ··· 571 571 iov_iter_bvec(&call->iter, READ, call->bvec, 1, size); 572 572 ASSERTCMP(size, <=, PAGE_SIZE); 573 573 574 - /* extract the returned data */ 574 + /* Fall through - and extract the returned data */ 575 575 case 2: 576 576 _debug("extract data %zu/%llu", 577 577 iov_iter_count(&call->iter), req->remain); ··· 598 598 /* Discard any excess data the server gave us */ 599 599 iov_iter_discard(&call->iter, READ, req->actual_len - req->len); 600 600 call->unmarshall = 3; 601 + 602 + /* Fall through */ 601 603 case 3: 602 604 _debug("extract discard %zu/%llu", 603 605 iov_iter_count(&call->iter), req->actual_len - req->len); ··· 615 613 sizeof(struct yfs_xdr_YFSCallBack) + 616 614 sizeof(struct yfs_xdr_YFSVolSync)); 617 615 618 - /* extract the metadata */ 616 + /* Fall through - and extract the metadata */ 619 617 case 4: 620 618 ret = afs_extract_data(call, false); 621 619 if (ret < 0) ··· 631 629 632 630 call->unmarshall++; 633 631 632 + /* Fall through */ 634 633 case 5: 635 634 break; 636 635 } ··· 1587 1584 call->unmarshall++; 1588 1585 afs_extract_to_buf(call, sizeof(struct yfs_xdr_YFSFetchVolumeStatus)); 1589 1586 1590 - /* extract the returned status record */ 1587 + /* Fall through - and extract the returned status record */ 1591 1588 case 1: 1592 1589 _debug("extract status"); 1593 1590 ret = afs_extract_data(call, true); ··· 1599 1596 call->unmarshall++; 1600 1597 afs_extract_to_tmp(call); 1601 1598 1602 - /* extract the volume name length */ 1599 + /* Fall through - and extract the volume name length */ 1603 1600 case 2: 1604 1601 ret = afs_extract_data(call, true); 1605 1602 if (ret < 0) ··· 1614 1611 afs_extract_begin(call, call->reply[2], size); 1615 1612 call->unmarshall++; 1616 1613 1617 - /* extract the volume name */ 1614 + /* Fall through - and extract the volume name */ 1618 1615 case 3: 1619 1616 _debug("extract volname"); 1620 1617 ret = afs_extract_data(call, true); ··· 1627 1624 afs_extract_to_tmp(call); 1628 1625 call->unmarshall++; 1629 1626 1630 - /* extract the offline message length */ 1627 + /* Fall through - and extract the offline message length */ 1631 1628 case 4: 1632 1629 ret = afs_extract_data(call, true); 1633 1630 if (ret < 0) ··· 1642 1639 afs_extract_begin(call, call->reply[2], size); 1643 1640 call->unmarshall++; 1644 1641 1645 - /* extract the offline message */ 1642 + /* Fall through - and extract the offline message */ 1646 1643 case 5: 1647 1644 _debug("extract offline"); 1648 1645 ret = afs_extract_data(call, true); ··· 1656 1653 afs_extract_to_tmp(call); 1657 1654 call->unmarshall++; 1658 1655 1659 - /* extract the message of the day length */ 1656 + /* Fall through - and extract the message of the day length */ 1660 1657 case 6: 1661 1658 ret = afs_extract_data(call, true); 1662 1659 if (ret < 0) ··· 1671 1668 afs_extract_begin(call, call->reply[2], size); 1672 1669 call->unmarshall++; 1673 1670 1674 - /* extract the message of the day */ 1671 + /* Fall through - and extract the message of the day */ 1675 1672 case 7: 1676 1673 _debug("extract motd"); 1677 1674 ret = afs_extract_data(call, false); ··· 1684 1681 1685 1682 call->unmarshall++; 1686 1683 1684 + /* Fall through */ 1687 1685 case 8: 1688 1686 break; 1689 1687 } ··· 2030 2026 call->unmarshall++; 2031 2027 2032 2028 /* Extract the file status count and array in two steps */ 2029 + /* Fall through */ 2033 2030 case 1: 2034 2031 _debug("extract status count"); 2035 2032 ret = afs_extract_data(call, true); ··· 2048 2043 more_counts: 2049 2044 afs_extract_to_buf(call, sizeof(struct yfs_xdr_YFSFetchStatus)); 2050 2045 2046 + /* Fall through */ 2051 2047 case 2: 2052 2048 _debug("extract status array %u", call->count); 2053 2049 ret = afs_extract_data(call, true); ··· 2072 2066 afs_extract_to_tmp(call); 2073 2067 2074 2068 /* Extract the callback count and array in two steps */ 2069 + /* Fall through */ 2075 2070 case 3: 2076 2071 _debug("extract CB count"); 2077 2072 ret = afs_extract_data(call, true); ··· 2089 2082 more_cbs: 2090 2083 afs_extract_to_buf(call, sizeof(struct yfs_xdr_YFSCallBack)); 2091 2084 2085 + /* Fall through */ 2092 2086 case 4: 2093 2087 _debug("extract CB array"); 2094 2088 ret = afs_extract_data(call, true); ··· 2112 2104 afs_extract_to_buf(call, sizeof(struct yfs_xdr_YFSVolSync)); 2113 2105 call->unmarshall++; 2114 2106 2107 + /* Fall through */ 2115 2108 case 5: 2116 2109 ret = afs_extract_data(call, false); 2117 2110 if (ret < 0) ··· 2123 2114 2124 2115 call->unmarshall++; 2125 2116 2117 + /* Fall through */ 2126 2118 case 6: 2127 2119 break; 2128 2120 }
+1
fs/btrfs/ref-verify.c
··· 509 509 switch (key.type) { 510 510 case BTRFS_EXTENT_ITEM_KEY: 511 511 *num_bytes = key.offset; 512 + /* fall through */ 512 513 case BTRFS_METADATA_ITEM_KEY: 513 514 *bytenr = key.objectid; 514 515 ret = process_extent_item(fs_info, path, &key, i,
+1
fs/btrfs/volumes.h
··· 394 394 return BTRFS_MAP_WRITE; 395 395 default: 396 396 WARN_ON_ONCE(1); 397 + /* fall through */ 397 398 case REQ_OP_READ: 398 399 return BTRFS_MAP_READ; 399 400 }
+1
fs/ceph/file.c
··· 247 247 case S_IFREG: 248 248 ceph_fscache_register_inode_cookie(inode); 249 249 ceph_fscache_file_set_cookie(inode, file); 250 + /* fall through */ 250 251 case S_IFDIR: 251 252 ret = ceph_init_file_info(inode, file, fmode, 252 253 S_ISDIR(inode->i_mode));
+2
fs/configfs/dir.c
··· 1690 1690 switch (whence) { 1691 1691 case 1: 1692 1692 offset += file->f_pos; 1693 + /* fall through */ 1693 1694 case 0: 1694 1695 if (offset >= 0) 1695 1696 break; 1697 + /* fall through */ 1696 1698 default: 1697 1699 return -EINVAL; 1698 1700 }
+2
fs/f2fs/node.c
··· 616 616 switch (dn->max_level) { 617 617 case 3: 618 618 base += 2 * indirect_blks; 619 + /* fall through */ 619 620 case 2: 620 621 base += 2 * direct_blks; 622 + /* fall through */ 621 623 case 1: 622 624 base += direct_index; 623 625 break;
+1 -1
fs/fcntl.c
··· 769 769 si.si_fd = fd; 770 770 if (!do_send_sig_info(signum, &si, p, type)) 771 771 break; 772 - /* fall-through: fall back on the old plain SIGIO signal */ 772 + /* fall-through - fall back on the old plain SIGIO signal */ 773 773 case 0: 774 774 do_send_sig_info(SIGIO, SEND_SIG_PRIV, p, type); 775 775 }
+2 -2
fs/gfs2/bmap.c
··· 710 710 } 711 711 if (n == 0) 712 712 break; 713 - /* Branching from existing tree */ 713 + /* fall through - To branching from existing tree */ 714 714 case ALLOC_GROW_DEPTH: 715 715 if (i > 1 && i < mp->mp_fheight) 716 716 gfs2_trans_add_meta(ip->i_gl, mp->mp_bh[i-1]); ··· 721 721 state = ALLOC_DATA; 722 722 if (n == 0) 723 723 break; 724 - /* Tree complete, adding data blocks */ 724 + /* fall through - To tree complete, adding data blocks */ 725 725 case ALLOC_DATA: 726 726 BUG_ON(n > dblks); 727 727 BUG_ON(mp->mp_bh[end_of_metadata] == NULL);
+1
fs/jffs2/fs.c
··· 340 340 rdev = old_decode_dev(je16_to_cpu(jdev.old_id)); 341 341 else 342 342 rdev = new_decode_dev(je32_to_cpu(jdev.new_id)); 343 + /* fall through */ 343 344 344 345 case S_IFSOCK: 345 346 case S_IFIFO:
+2
fs/libfs.c
··· 146 146 switch (whence) { 147 147 case 1: 148 148 offset += file->f_pos; 149 + /* fall through */ 149 150 case 0: 150 151 if (offset >= 0) 151 152 break; 153 + /* fall through */ 152 154 default: 153 155 return -EINVAL; 154 156 }
+1 -1
fs/locks.c
··· 1476 1476 switch (arg) { 1477 1477 case F_UNLCK: 1478 1478 fl->fl_flags &= ~FL_UNLOCK_PENDING; 1479 - /* fall through: */ 1479 + /* fall through */ 1480 1480 case F_RDLCK: 1481 1481 fl->fl_flags &= ~FL_DOWNGRADE_PENDING; 1482 1482 }
+1
fs/nfsd/nfs4proc.c
··· 427 427 goto out; 428 428 open->op_openowner->oo_flags |= NFS4_OO_CONFIRMED; 429 429 reclaim = true; 430 + /* fall through */ 430 431 case NFS4_OPEN_CLAIM_FH: 431 432 case NFS4_OPEN_CLAIM_DELEG_CUR_FH: 432 433 status = do_open_fhandle(rqstp, cstate, open);
+1
fs/nfsd/nfs4state.c
··· 2585 2585 break; 2586 2586 default: /* checked by xdr code */ 2587 2587 WARN_ON_ONCE(1); 2588 + /* fall through */ 2588 2589 case SP4_SSV: 2589 2590 status = nfserr_encr_alg_unsupp; 2590 2591 goto out_nolock;
+1
fs/ocfs2/cluster/quorum.c
··· 81 81 default: 82 82 WARN_ON(o2nm_single_cluster->cl_fence_method >= 83 83 O2NM_FENCE_METHODS); 84 + /* fall through */ 84 85 case O2NM_FENCE_RESET: 85 86 printk(KERN_ERR "*** ocfs2 is very sorry to be fencing this " 86 87 "system by restarting ***\n");
+1
fs/seq_file.c
··· 317 317 switch (whence) { 318 318 case SEEK_CUR: 319 319 offset += file->f_pos; 320 + /* fall through */ 320 321 case SEEK_SET: 321 322 if (offset < 0) 322 323 break;
+1
fs/signalfd.c
··· 176 176 if (!nonblock) 177 177 break; 178 178 ret = -EAGAIN; 179 + /* fall through */ 179 180 default: 180 181 spin_unlock_irq(&current->sighand->siglock); 181 182 return ret;
+2 -2
fs/ufs/util.h
··· 42 42 case UFS_ST_SUNOS: 43 43 if (fs32_to_cpu(sb, usb3->fs_postblformat) == UFS_42POSTBLFMT) 44 44 return fs32_to_cpu(sb, usb1->fs_u0.fs_sun.fs_state); 45 - /* Fall Through to UFS_ST_SUN */ 45 + /* Fall Through - to UFS_ST_SUN */ 46 46 case UFS_ST_SUN: 47 47 return fs32_to_cpu(sb, usb3->fs_un2.fs_sun.fs_state); 48 48 case UFS_ST_SUNx86: ··· 63 63 usb1->fs_u0.fs_sun.fs_state = cpu_to_fs32(sb, value); 64 64 break; 65 65 } 66 - /* Fall Through to UFS_ST_SUN */ 66 + /* Fall Through - to UFS_ST_SUN */ 67 67 case UFS_ST_SUN: 68 68 usb3->fs_un2.fs_sun.fs_state = cpu_to_fs32(sb, value); 69 69 break;
+4
lib/asn1_decoder.c
··· 385 385 case ASN1_OP_END_SET_ACT: 386 386 if (unlikely(!(flags & FLAG_MATCHED))) 387 387 goto tag_mismatch; 388 + /* fall through */ 389 + 388 390 case ASN1_OP_END_SEQ: 389 391 case ASN1_OP_END_SET_OF: 390 392 case ASN1_OP_END_SEQ_OF: ··· 452 450 pc += asn1_op_lengths[op]; 453 451 goto next_op; 454 452 } 453 + /* fall through */ 454 + 455 455 case ASN1_OP_ACT: 456 456 ret = actions[machine[pc + 1]](context, hdr, tag, data + tdp, len); 457 457 if (ret < 0)
+5
lib/cmdline.c
··· 135 135 case 'E': 136 136 case 'e': 137 137 ret <<= 10; 138 + /* fall through */ 138 139 case 'P': 139 140 case 'p': 140 141 ret <<= 10; 142 + /* fall through */ 141 143 case 'T': 142 144 case 't': 143 145 ret <<= 10; 146 + /* fall through */ 144 147 case 'G': 145 148 case 'g': 146 149 ret <<= 10; 150 + /* fall through */ 147 151 case 'M': 148 152 case 'm': 149 153 ret <<= 10; 154 + /* fall through */ 150 155 case 'K': 151 156 case 'k': 152 157 ret <<= 10;
+5
lib/zstd/bitstream.h
··· 259 259 bitD->bitContainer = *(const BYTE *)(bitD->start); 260 260 switch (srcSize) { 261 261 case 7: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[6]) << (sizeof(bitD->bitContainer) * 8 - 16); 262 + /* fall through */ 262 263 case 6: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[5]) << (sizeof(bitD->bitContainer) * 8 - 24); 264 + /* fall through */ 263 265 case 5: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[4]) << (sizeof(bitD->bitContainer) * 8 - 32); 266 + /* fall through */ 264 267 case 4: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[3]) << 24; 268 + /* fall through */ 265 269 case 3: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[2]) << 16; 270 + /* fall through */ 266 271 case 2: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[1]) << 8; 267 272 default:; 268 273 }
+1
lib/zstd/compress.c
··· 3182 3182 zcs->outBuffFlushedSize = 0; 3183 3183 zcs->stage = zcss_flush; /* pass-through to flush stage */ 3184 3184 } 3185 + /* fall through */ 3185 3186 3186 3187 case zcss_flush: { 3187 3188 size_t const toFlush = zcs->outBuffContentSize - zcs->outBuffFlushedSize;
+4 -1
lib/zstd/decompress.c
··· 1768 1768 return 0; 1769 1769 } 1770 1770 dctx->expected = 0; /* not necessary to copy more */ 1771 + /* fall through */ 1771 1772 1772 1773 case ZSTDds_decodeFrameHeader: 1773 1774 memcpy(dctx->headerBuffer + ZSTD_frameHeaderSize_prefix, src, dctx->expected); ··· 2376 2375 } 2377 2376 zds->stage = zdss_read; 2378 2377 } 2379 - /* pass-through */ 2378 + /* fall through */ 2380 2379 2381 2380 case zdss_read: { 2382 2381 size_t const neededInSize = ZSTD_nextSrcSizeToDecompress(zds->dctx); ··· 2405 2404 zds->stage = zdss_load; 2406 2405 /* pass-through */ 2407 2406 } 2407 + /* fall through */ 2408 2408 2409 2409 case zdss_load: { 2410 2410 size_t const neededInSize = ZSTD_nextSrcSizeToDecompress(zds->dctx); ··· 2438 2436 /* pass-through */ 2439 2437 } 2440 2438 } 2439 + /* fall through */ 2441 2440 2442 2441 case zdss_flush: { 2443 2442 size_t const toFlushSize = zds->outEnd - zds->outStart;
+2
lib/zstd/huf_compress.c
··· 556 556 n = srcSize & ~3; /* join to mod 4 */ 557 557 switch (srcSize & 3) { 558 558 case 3: HUF_encodeSymbol(&bitC, ip[n + 2], CTable); HUF_FLUSHBITS_2(&bitC); 559 + /* fall through */ 559 560 case 2: HUF_encodeSymbol(&bitC, ip[n + 1], CTable); HUF_FLUSHBITS_1(&bitC); 561 + /* fall through */ 560 562 case 1: HUF_encodeSymbol(&bitC, ip[n + 0], CTable); HUF_FLUSHBITS(&bitC); 561 563 case 0: 562 564 default:;