Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: sharp-ls043t1le01: Don't call disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by Qualcomm boards. The Qualcomm driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Cc: Werner Johansson <werner.johansson@sonymobile.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240604172305.v3.20.I89ee53f7fc2f0806cab318128e5fa927990d830f@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240604172305.v3.20.I89ee53f7fc2f0806cab318128e5fa927990d830f@changeid

authored by

Douglas Anderson and committed by
Neil Armstrong
b3494ccb 804c4d0a

-12
-12
drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
··· 267 267 struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi); 268 268 int ret; 269 269 270 - ret = drm_panel_disable(&sharp_nt->base); 271 - if (ret < 0) 272 - dev_err(&dsi->dev, "failed to disable panel: %d\n", ret); 273 - 274 270 ret = mipi_dsi_detach(dsi); 275 271 if (ret < 0) 276 272 dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); 277 273 278 274 sharp_nt_panel_del(sharp_nt); 279 - } 280 - 281 - static void sharp_nt_panel_shutdown(struct mipi_dsi_device *dsi) 282 - { 283 - struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi); 284 - 285 - drm_panel_disable(&sharp_nt->base); 286 275 } 287 276 288 277 static const struct of_device_id sharp_nt_of_match[] = { ··· 287 298 }, 288 299 .probe = sharp_nt_panel_probe, 289 300 .remove = sharp_nt_panel_remove, 290 - .shutdown = sharp_nt_panel_shutdown, 291 301 }; 292 302 module_mipi_dsi_driver(sharp_nt_panel_driver); 293 303