Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: sharp-ls043t1le01: Stop tracking prepared

As talked about in commit d2aacaf07395 ("drm/panel: Check for already
prepared/enabled in drm_panel"), we want to remove needless code from
panel drivers that was storing and double-checking the
prepared/enabled state. Even if someone was relying on the
double-check before, that double-check is now in the core and not
needed in individual drivers.

Cc: Werner Johansson <werner.johansson@sonymobile.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240604172305.v3.19.I56849dbe7c906f0cff076dc5286fd05c7e3e9c18@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240604172305.v3.19.I56849dbe7c906f0cff076dc5286fd05c7e3e9c18@changeid

authored by

Douglas Anderson and committed by
Neil Armstrong
804c4d0a d7d473d8

-12
-12
drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
··· 26 26 27 27 struct regulator *supply; 28 28 struct gpio_desc *reset_gpio; 29 - 30 - bool prepared; 31 29 }; 32 30 33 31 static inline struct sharp_nt_panel *to_sharp_nt_panel(struct drm_panel *panel) ··· 97 99 struct sharp_nt_panel *sharp_nt = to_sharp_nt_panel(panel); 98 100 int ret; 99 101 100 - if (!sharp_nt->prepared) 101 - return 0; 102 - 103 102 ret = sharp_nt_panel_off(sharp_nt); 104 103 if (ret < 0) { 105 104 dev_err(panel->dev, "failed to set panel off: %d\n", ret); ··· 107 112 if (sharp_nt->reset_gpio) 108 113 gpiod_set_value(sharp_nt->reset_gpio, 0); 109 114 110 - sharp_nt->prepared = false; 111 - 112 115 return 0; 113 116 } 114 117 ··· 114 121 { 115 122 struct sharp_nt_panel *sharp_nt = to_sharp_nt_panel(panel); 116 123 int ret; 117 - 118 - if (sharp_nt->prepared) 119 - return 0; 120 124 121 125 ret = regulator_enable(sharp_nt->supply); 122 126 if (ret < 0) ··· 141 151 dev_err(panel->dev, "failed to set panel on: %d\n", ret); 142 152 goto poweroff; 143 153 } 144 - 145 - sharp_nt->prepared = true; 146 154 147 155 return 0; 148 156