Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reset: k210: fix OF node leak in probe() error path

Driver is leaking OF node reference on memory allocation failure.
Acquire the OF node reference after memory allocation to fix this and
keep it simple.

Fixes: 5a2308da9f60 ("riscv: Add Canaan Kendryte K210 reset controller")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20240825-reset-cleanup-scoped-v1-2-03f6d834f8c0@linaro.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

authored by

Krzysztof Kozlowski and committed by
Philipp Zabel
b14e40f5 5f58a88c

+2 -1
+2 -1
drivers/reset/reset-k210.c
··· 90 90 static int k210_rst_probe(struct platform_device *pdev) 91 91 { 92 92 struct device *dev = &pdev->dev; 93 - struct device_node *parent_np = of_get_parent(dev->of_node); 93 + struct device_node *parent_np; 94 94 struct k210_rst *ksr; 95 95 96 96 dev_info(dev, "K210 reset controller\n"); ··· 99 99 if (!ksr) 100 100 return -ENOMEM; 101 101 102 + parent_np = of_get_parent(dev->of_node); 102 103 ksr->map = syscon_node_to_regmap(parent_np); 103 104 of_node_put(parent_np); 104 105 if (IS_ERR(ksr->map))