Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reset: berlin: fix OF node leak in probe() error path

Driver is leaking OF node reference on memory allocation failure.
Acquire the OF node reference after memory allocation to fix this and
keep it simple.

Fixes: aed6f3cadc86 ("reset: berlin: convert to a platform driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20240825-reset-cleanup-scoped-v1-1-03f6d834f8c0@linaro.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

authored by

Krzysztof Kozlowski and committed by
Philipp Zabel
5f58a88c 6bbc0fa2

+2 -1
+2 -1
drivers/reset/reset-berlin.c
··· 68 68 69 69 static int berlin2_reset_probe(struct platform_device *pdev) 70 70 { 71 - struct device_node *parent_np = of_get_parent(pdev->dev.of_node); 71 + struct device_node *parent_np; 72 72 struct berlin_reset_priv *priv; 73 73 74 74 priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); 75 75 if (!priv) 76 76 return -ENOMEM; 77 77 78 + parent_np = of_get_parent(pdev->dev.of_node); 78 79 priv->regmap = syscon_node_to_regmap(parent_np); 79 80 of_node_put(parent_np); 80 81 if (IS_ERR(priv->regmap))