Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: humidity: hid-sensor-humidity: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-36-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
b06ab8c8 3a879973

+2 -4
+2 -4
drivers/iio/humidity/hid-sensor-humidity.c
··· 260 260 } 261 261 262 262 /* Function to deinitialize the processing for usage id */ 263 - static int hid_humidity_remove(struct platform_device *pdev) 263 + static void hid_humidity_remove(struct platform_device *pdev) 264 264 { 265 265 struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev); 266 266 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 269 269 iio_device_unregister(indio_dev); 270 270 sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_HUMIDITY); 271 271 hid_sensor_remove_trigger(indio_dev, &humid_st->common_attributes); 272 - 273 - return 0; 274 272 } 275 273 276 274 static const struct platform_device_id hid_humidity_ids[] = { ··· 287 289 .pm = &hid_sensor_pm_ops, 288 290 }, 289 291 .probe = hid_humidity_probe, 290 - .remove = hid_humidity_remove, 292 + .remove_new = hid_humidity_remove, 291 293 }; 292 294 module_platform_driver(hid_humidity_platform_driver); 293 295