Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: gyro: hid-sensor-gyro-3d: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-35-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
3a879973 cf22fc55

+2 -4
+2 -4
drivers/iio/gyro/hid-sensor-gyro-3d.c
··· 359 359 } 360 360 361 361 /* Function to deinitialize the processing for usage id */ 362 - static int hid_gyro_3d_remove(struct platform_device *pdev) 362 + static void hid_gyro_3d_remove(struct platform_device *pdev) 363 363 { 364 364 struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data; 365 365 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 368 368 sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_GYRO_3D); 369 369 iio_device_unregister(indio_dev); 370 370 hid_sensor_remove_trigger(indio_dev, &gyro_state->common_attributes); 371 - 372 - return 0; 373 371 } 374 372 375 373 static const struct platform_device_id hid_gyro_3d_ids[] = { ··· 386 388 .pm = &hid_sensor_pm_ops, 387 389 }, 388 390 .probe = hid_gyro_3d_probe, 389 - .remove = hid_gyro_3d_remove, 391 + .remove_new = hid_gyro_3d_remove, 390 392 }; 391 393 module_platform_driver(hid_gyro_3d_platform_driver); 392 394