Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: dsa: hellcreek: Replace bogus comment

Replace bogus comment about matching the latched timestamp to one of the
received frames. That comment is probably copied from mv88e6xxx and true for
these switches. However, the hellcreek switch is configured to insert the
timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as
well, because it doesn't add any value.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20230801131647.84697-1-kurt@linutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Kurt Kanzenbach and committed by
Jakub Kicinski
ae3683a3 ae336f30

+1 -8
+1 -8
drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c
··· 298 298 struct sk_buff_head received; 299 299 unsigned long flags; 300 300 301 - /* The latched timestamp belongs to one of the received frames. */ 301 + /* Construct Rx timestamps for all received PTP packets. */ 302 302 __skb_queue_head_init(&received); 303 - 304 - /* Lock & disable interrupts */ 305 303 spin_lock_irqsave(&rxq->lock, flags); 306 - 307 - /* Add the reception queue "rxq" to the "received" queue an reintialize 308 - * "rxq". From now on, we deal with "received" not with "rxq" 309 - */ 310 304 skb_queue_splice_tail_init(rxq, &received); 311 - 312 305 spin_unlock_irqrestore(&rxq->lock, flags); 313 306 314 307 for (; skb; skb = __skb_dequeue(&received)) {