tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

bnx2x: Remove unnecessary ternary operators

There are a little ternary operators, the true or false judgement
of which is unnecessary in C language semantics.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230801111928.300231-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Ruan Jinjie and committed by
Jakub Kicinski ae336f30 c7606d49

+3 -3
+3 -3
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
··· 890 890 (struct eth_classify_rules_ramrod_data *)(raw->rdata); 891 891 int rule_cnt = rule_idx + 1, cmd = elem->cmd_data.vlan_mac.cmd; 892 892 union eth_classify_rule_cmd *rule_entry = &data->rules[rule_idx]; 893 - bool add = (cmd == BNX2X_VLAN_MAC_ADD) ? true : false; 893 + bool add = cmd == BNX2X_VLAN_MAC_ADD; 894 894 unsigned long *vlan_mac_flags = &elem->cmd_data.vlan_mac.vlan_mac_flags; 895 895 u8 *mac = elem->cmd_data.vlan_mac.u.mac.mac; 896 896 ··· 1075 1075 int rule_cnt = rule_idx + 1; 1076 1076 union eth_classify_rule_cmd *rule_entry = &data->rules[rule_idx]; 1077 1077 enum bnx2x_vlan_mac_cmd cmd = elem->cmd_data.vlan_mac.cmd; 1078 - bool add = (cmd == BNX2X_VLAN_MAC_ADD) ? true : false; 1078 + bool add = cmd == BNX2X_VLAN_MAC_ADD; 1079 1079 u16 vlan = elem->cmd_data.vlan_mac.u.vlan.vlan; 1080 1080 1081 1081 /* Reset the ramrod data buffer for the first rule */ ··· 1125 1125 int rule_cnt = rule_idx + 1; 1126 1126 union eth_classify_rule_cmd *rule_entry = &data->rules[rule_idx]; 1127 1127 enum bnx2x_vlan_mac_cmd cmd = elem->cmd_data.vlan_mac.cmd; 1128 - bool add = (cmd == BNX2X_VLAN_MAC_ADD) ? true : false; 1128 + bool add = cmd == BNX2X_VLAN_MAC_ADD; 1129 1129 u16 vlan = elem->cmd_data.vlan_mac.u.vlan_mac.vlan; 1130 1130 u8 *mac = elem->cmd_data.vlan_mac.u.vlan_mac.mac; 1131 1131 u16 inner_mac;