Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: rc5t583: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230304133028.2135435-27-u.kleine-koenig@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Uwe Kleine-König and committed by
Alexandre Belloni
ade527dd 3fc5029a

+2 -3
+2 -3
drivers/rtc/rtc-rc5t583.c
··· 262 262 * Disable rc5t583 RTC interrupts. 263 263 * Sets status flag to free. 264 264 */ 265 - static int rc5t583_rtc_remove(struct platform_device *pdev) 265 + static void rc5t583_rtc_remove(struct platform_device *pdev) 266 266 { 267 267 struct rc5t583_rtc *rc5t583_rtc = platform_get_drvdata(pdev); 268 268 269 269 rc5t583_rtc_alarm_irq_enable(&rc5t583_rtc->rtc->dev, 0); 270 - return 0; 271 270 } 272 271 273 272 #ifdef CONFIG_PM_SLEEP ··· 298 299 299 300 static struct platform_driver rc5t583_rtc_driver = { 300 301 .probe = rc5t583_rtc_probe, 301 - .remove = rc5t583_rtc_remove, 302 + .remove_new = rc5t583_rtc_remove, 302 303 .driver = { 303 304 .name = "rtc-rc5t583", 304 305 .pm = &rc5t583_rtc_pm_ops,